From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhZuH-0002Bc-TC for qemu-devel@nongnu.org; Mon, 13 Apr 2015 04:39:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhZuD-00063a-Ej for qemu-devel@nongnu.org; Mon, 13 Apr 2015 04:39:49 -0400 Received: from mail-wi0-x234.google.com ([2a00:1450:400c:c05::234]:36413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhZuD-00062W-72 for qemu-devel@nongnu.org; Mon, 13 Apr 2015 04:39:45 -0400 Received: by wizk4 with SMTP id k4so63035161wiz.1 for ; Mon, 13 Apr 2015 01:39:43 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <552B80CB.6040407@redhat.com> Date: Mon, 13 Apr 2015 10:39:39 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1428436304-24044-1-git-send-email-minyard@acm.org> <1428436304-24044-15-git-send-email-minyard@acm.org> <20150412180834-mutt-send-email-mst@redhat.com> <552B1C45.1080304@acm.org> <20150413082924-mutt-send-email-mst@redhat.com> In-Reply-To: <20150413082924-mutt-send-email-mst@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , Corey Minyard Cc: Corey Minyard , qemu-devel@nongnu.org On 13/04/2015 08:36, Michael S. Tsirkin wrote: >> > So you are suggesting each device add it's own SSDT? I'm not sure how >> > that helps debugging, it seems simpler to add it to a common one. > For example, it's easier to write a unit test: encode something specific > in one of the IDs, then look it up. > Which is, btw, something that's missing in this patchset. A unit test for what? Paolo