qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Nadav Amit <namit@cs.technion.ac.il>
Cc: jan.kiszka@siemens.com, bsd@redhat.com, qemu-devel@nongnu.org,
	kvm@vger.kernel.org, avi.kivity@gmail.com
Subject: Re: [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset
Date: Mon, 13 Apr 2015 16:12:45 +0200	[thread overview]
Message-ID: <552BCEDD.9040405@redhat.com> (raw)
In-Reply-To: <1428881529-29459-2-git-send-email-namit@cs.technion.ac.il>



On 13/04/2015 01:32, Nadav Amit wrote:
> Due to old Seabios bug, QEMU reenable LINT0 after reset. This bug is long gone
> and therefore this hack is no longer needed.  Since it violates the
> specifications, it is removed.
> 
> Signed-off-by: Nadav Amit <namit@cs.technion.ac.il>
> ---
>  hw/intc/apic_common.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c
> index 042e960..d38d24b 100644
> --- a/hw/intc/apic_common.c
> +++ b/hw/intc/apic_common.c
> @@ -243,15 +243,6 @@ static void apic_reset_common(DeviceState *dev)
>      info->vapic_base_update(s);
>  
>      apic_init_reset(dev);
> -
> -    if (bsp) {
> -        /*
> -         * LINT0 delivery mode on CPU #0 is set to ExtInt at initialization
> -         * time typically by BIOS, so PIC interrupt can be delivered to the
> -         * processor when local APIC is enabled.
> -         */
> -        s->lvt[APIC_LVT_LINT0] = 0x700;
> -    }
>  }
>  
>  /* This function is only used for old state version 1 and 2 */
> 

Thanks, applied this one.  The other will have to wait for a bit, since
it depends on a patch that is destined to Linux 4.2.

Paolo

  reply	other threads:[~2015-04-13 14:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-12 23:32 [Qemu-devel] [PATCH 0/2] target-i386: disable LINT0 after reset and init Nadav Amit
2015-04-12 23:32 ` [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset Nadav Amit
2015-04-13 14:12   ` Paolo Bonzini [this message]
2015-09-15 21:19   ` Alex Williamson
2015-09-16  5:23     ` Jan Kiszka
2015-09-16  6:22       ` Nadav Amit
2015-09-16  6:47       ` Gerd Hoffmann
2015-09-16 12:52         ` Nadav Amit
2015-04-12 23:32 ` [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks Nadav Amit
2015-04-13 14:13   ` Paolo Bonzini
2015-04-13 14:17     ` Nadav Amit
2015-04-13 14:24       ` Paolo Bonzini
2015-04-13 14:33         ` Nadav Amit
2015-04-13 14:36           ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552BCEDD.9040405@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=avi.kivity@gmail.com \
    --cc=bsd@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    --cc=namit@cs.technion.ac.il \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).