From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yhf6l-0003yw-JX for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:13:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yhf6g-0001Nu-Ht for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:13:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yhf6g-0001Nh-BA for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:12:58 -0400 Message-ID: <552BCEDD.9040405@redhat.com> Date: Mon, 13 Apr 2015 16:12:45 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1428881529-29459-1-git-send-email-namit@cs.technion.ac.il> <1428881529-29459-2-git-send-email-namit@cs.technion.ac.il> In-Reply-To: <1428881529-29459-2-git-send-email-namit@cs.technion.ac.il> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nadav Amit Cc: jan.kiszka@siemens.com, bsd@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, avi.kivity@gmail.com On 13/04/2015 01:32, Nadav Amit wrote: > Due to old Seabios bug, QEMU reenable LINT0 after reset. This bug is long gone > and therefore this hack is no longer needed. Since it violates the > specifications, it is removed. > > Signed-off-by: Nadav Amit > --- > hw/intc/apic_common.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/hw/intc/apic_common.c b/hw/intc/apic_common.c > index 042e960..d38d24b 100644 > --- a/hw/intc/apic_common.c > +++ b/hw/intc/apic_common.c > @@ -243,15 +243,6 @@ static void apic_reset_common(DeviceState *dev) > info->vapic_base_update(s); > > apic_init_reset(dev); > - > - if (bsp) { > - /* > - * LINT0 delivery mode on CPU #0 is set to ExtInt at initialization > - * time typically by BIOS, so PIC interrupt can be delivered to the > - * processor when local APIC is enabled. > - */ > - s->lvt[APIC_LVT_LINT0] = 0x700; > - } > } > > /* This function is only used for old state version 1 and 2 */ > Thanks, applied this one. The other will have to wait for a bit, since it depends on a patch that is destined to Linux 4.2. Paolo