From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53256)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Yhf7N-0004pm-3q
	for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:13:41 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Yhf7J-0001Xo-7V
	for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:13:41 -0400
Received: from mx1.redhat.com ([209.132.183.28]:31562)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Yhf7I-0001Xe-QB
	for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:13:37 -0400
Message-ID: <552BCF05.8020504@redhat.com>
Date: Mon, 13 Apr 2015 16:13:25 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1428881529-29459-1-git-send-email-namit@cs.technion.ac.il>
	<1428881529-29459-3-git-send-email-namit@cs.technion.ac.il>
In-Reply-To: <1428881529-29459-3-git-send-email-namit@cs.technion.ac.il>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nadav Amit <namit@cs.technion.ac.il>
Cc: jan.kiszka@siemens.com, bsd@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, avi.kivity@gmail.com



On 13/04/2015 01:32, Nadav Amit wrote:
> +    if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) {

The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not
KVM_CAP_ENABLE_CAP_VM.

Paolo

> +        ret = kvm_vm_enable_cap(s, KVM_CAP_DISABLE_QUIRKS, 0,
> +                                KVM_QUIRK_LINT0_DISABLED |
> +                                KVM_QUIRK_CD_NW_CLEARED);
> +        if (ret < 0) {
> +            return ret;
> +        }
> +    }