From: Paolo Bonzini <pbonzini@redhat.com>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: kvm list <kvm@vger.kernel.org>,
Nadav Amit <namit@cs.technion.ac.il>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, Bandan Das <bsd@redhat.com>,
avi.kivity@gmail.com
Subject: Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks
Date: Mon, 13 Apr 2015 16:24:55 +0200 [thread overview]
Message-ID: <552BD1B7.4080103@redhat.com> (raw)
In-Reply-To: <D4B2EE7B-9F20-41CC-B320-FAAF0BD5E06C@gmail.com>
On 13/04/2015 16:17, Nadav Amit wrote:
> Paolo Bonzini <pbonzini@redhat.com> wrote:
>
>>
>>
>> On 13/04/2015 01:32, Nadav Amit wrote:
>>> + if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) {
>>
>> The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not
>> KVM_CAP_ENABLE_CAP_VM.
>>
>> Paolo
>>
>>> + ret = kvm_vm_enable_cap(s, KVM_CAP_DISABLE_QUIRKS, 0,
>>> + KVM_QUIRK_LINT0_DISABLED |
>>> + KVM_QUIRK_CD_NW_CLEARED);
>>> + if (ret < 0) {
>>> + return ret;
>>> + }
>>> + }
>
> Of course…
> Do you want a v2 now, later (after 4.2), or would you change it yourself?
Later, close to 4.2 but not necessarily after it.
Paolo
next prev parent reply other threads:[~2015-04-13 14:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-12 23:32 [Qemu-devel] [PATCH 0/2] target-i386: disable LINT0 after reset and init Nadav Amit
2015-04-12 23:32 ` [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset Nadav Amit
2015-04-13 14:12 ` Paolo Bonzini
2015-09-15 21:19 ` Alex Williamson
2015-09-16 5:23 ` Jan Kiszka
2015-09-16 6:22 ` Nadav Amit
2015-09-16 6:47 ` Gerd Hoffmann
2015-09-16 12:52 ` Nadav Amit
2015-04-12 23:32 ` [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks Nadav Amit
2015-04-13 14:13 ` Paolo Bonzini
2015-04-13 14:17 ` Nadav Amit
2015-04-13 14:24 ` Paolo Bonzini [this message]
2015-04-13 14:33 ` Nadav Amit
2015-04-13 14:36 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552BD1B7.4080103@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi.kivity@gmail.com \
--cc=bsd@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
--cc=nadav.amit@gmail.com \
--cc=namit@cs.technion.ac.il \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).