From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55748)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YhfIW-0002zG-1s
	for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:25:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YhfIQ-0006Q4-72
	for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:25:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33508)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1YhfIQ-0006Nk-04
	for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:25:06 -0400
Message-ID: <552BD1B7.4080103@redhat.com>
Date: Mon, 13 Apr 2015 16:24:55 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1428881529-29459-1-git-send-email-namit@cs.technion.ac.il>
	<1428881529-29459-3-git-send-email-namit@cs.technion.ac.il>
	<552BCF05.8020504@redhat.com>
	<D4B2EE7B-9F20-41CC-B320-FAAF0BD5E06C@gmail.com>
In-Reply-To: <D4B2EE7B-9F20-41CC-B320-FAAF0BD5E06C@gmail.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/2] target-i386: kvm: Disable KVM quirks
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nadav Amit <nadav.amit@gmail.com>
Cc: kvm list <kvm@vger.kernel.org>, Nadav Amit <namit@cs.technion.ac.il>, Jan Kiszka <jan.kiszka@siemens.com>, qemu-devel@nongnu.org, Bandan Das <bsd@redhat.com>, avi.kivity@gmail.com



On 13/04/2015 16:17, Nadav Amit wrote:
> Paolo Bonzini <pbonzini@redhat.com> wrote:
>=20
>>
>>
>> On 13/04/2015 01:32, Nadav Amit wrote:
>>> +    if (kvm_check_extension(s, KVM_CAP_ENABLE_CAP_VM)) {
>>
>> The right capability to check here is KVM_CAP_DISABLE_QUIRKS, not
>> KVM_CAP_ENABLE_CAP_VM.
>>
>> Paolo
>>
>>> +        ret =3D kvm_vm_enable_cap(s, KVM_CAP_DISABLE_QUIRKS, 0,
>>> +                                KVM_QUIRK_LINT0_DISABLED |
>>> +                                KVM_QUIRK_CD_NW_CLEARED);
>>> +        if (ret < 0) {
>>> +            return ret;
>>> +        }
>>> +    }
>=20
> Of course=85
> Do you want a v2 now, later (after 4.2), or would you change it yoursel=
f?

Later, close to 4.2 but not necessarily after it.

Paolo