From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhfX9-0001IL-6a for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:40:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhfX4-00041H-Pb for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:40:19 -0400 Received: from resqmta-po-10v.sys.comcast.net ([2001:558:fe16:19:96:114:154:169]:55019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhfX4-00040V-KT for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:40:14 -0400 Message-ID: <552BD54B.6080004@redhat.com> Date: Mon, 13 Apr 2015 08:40:11 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427995743-7865-1-git-send-email-armbru@redhat.com> <1427995743-7865-6-git-send-email-armbru@redhat.com> In-Reply-To: <1427995743-7865-6-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lDNMJsQkugrmOcmjsvk2TkWuL6DqwJJQL" Subject: Re: [Qemu-devel] [PATCH RFC 05/19] qapi: Simplify c_enum_const() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, akong@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lDNMJsQkugrmOcmjsvk2TkWuL6DqwJJQL Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/02/2015 11:28 AM, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > scripts/qapi.py | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/scripts/qapi.py b/scripts/qapi.py > index e1c5ef2..3601d1d 100644 > --- a/scripts/qapi.py > +++ b/scripts/qapi.py > @@ -906,6 +906,4 @@ def camel_to_upper(value): > return new_name.lstrip('_').upper() > =20 > def c_enum_const(type_name, const_name): > - abbrev_string =3D camel_to_upper(type_name) > - value_string =3D camel_to_upper(const_name) > - return "%s_%s" % (abbrev_string, value_string) > + return camel_to_upper(type_name + '_' + const_name) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lDNMJsQkugrmOcmjsvk2TkWuL6DqwJJQL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVK9VLAAoJEKeha0olJ0NqwQAIAI5ciYlhYzNAkUKw5VcTtqfw 9pw3mhqDevXuUP033pj6t4NiDufYeRT81d2DjhZJ98o8E13rElPCHsGAcjmXJJq+ mFJ+D2oQPBRQdGf3f7/x9qrMGyoLcCLFRNLp0y9TxhCBIditKeJ3c9hOL5SFcptl Jr9ueof0d1seZLKZArW+blKo2RZEGOx4/29u+h56olc+pKhxsEZ5+X6us08cX604 jwV0ZGUv+K/AOBXDt/1jGeYTv82pDzLVLAqUPZu3sGSBhr3konthpA3zzbCnp9ev ThHloO8OsjiAnNvklMyA5P2IhwqOa1JwfjuPf0ImY6G5fWFUPPgW1wEyTfnlpQY= =TGcf -----END PGP SIGNATURE----- --lDNMJsQkugrmOcmjsvk2TkWuL6DqwJJQL--