From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59764) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhfaW-0003dV-Q9 for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:43:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhfaU-0004jc-9S for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:43:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhfaU-0004jV-2A for qemu-devel@nongnu.org; Mon, 13 Apr 2015 10:43:46 -0400 Message-ID: <552BD606.5060406@redhat.com> Date: Mon, 13 Apr 2015 16:43:18 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <22addebd05899a031834f63dbfe4358c5d38ac9e.1427954659.git.zhugh.fnst@cn.fujitsu.com> <5527EE2D.5040502@redhat.com> <552B2247.70104@cn.fujitsu.com> <552BD544.2030800@redhat.com> In-Reply-To: <552BD544.2030800@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 8/8] qmp-event: add event notification for memory hot unplug error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , Zhu Guihua , qemu-devel@nongnu.org, imammedo@redhat.com, mst@redhat.com Cc: guz.fnst@cn.fujitsu.com, izumi.taku@jp.fujitsu.com, tangchen@cn.fujitsu.com On 13/04/2015 16:40, Eric Blake wrote: >>>> +## >>>> >>> +# @MEM_UNPLUG_ERROR >>>> >>> +# >>>> >>> +# Emitted when memory hot unplug error occurs. >>>> >>> +# >>>> >>> +# @device: device name >>>> >>> +# >>>> >>> +# @msg: Informative message >>> >> Any reason you abbreviated instead of spelling it out as 'message'? >> > >> > This only refer to the spelling of event BLOCK_IMAGE_CORRUPTED >> > in docs/qmp/qmp-events.txt. > Just because existing code abbreviated does not mean that new code needs > to copy the bad example. To some extent it does; consistency is a good thing to have. So I think "msg" is okay here. Paolo