From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58062) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhhPq-0001z0-Pw for qemu-devel@nongnu.org; Mon, 13 Apr 2015 12:40:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhhPn-0002Rf-HY for qemu-devel@nongnu.org; Mon, 13 Apr 2015 12:40:54 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:35971) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhhPn-0002QJ-9v for qemu-devel@nongnu.org; Mon, 13 Apr 2015 12:40:51 -0400 Received: by wizk4 with SMTP id k4so80613658wiz.1 for ; Mon, 13 Apr 2015 09:40:50 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <552BF18E.2010602@redhat.com> Date: Mon, 13 Apr 2015 18:40:46 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1428436304-24044-1-git-send-email-minyard@acm.org> <1428436304-24044-11-git-send-email-minyard@acm.org> <20150412160524.GA13212@redhat.com> <552B1B56.1000709@acm.org> <20150413085824-mutt-send-email-mst@redhat.com> <552BF029.4040609@acm.org> In-Reply-To: <552BF029.4040609@acm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: minyard@acm.org, "Michael S. Tsirkin" Cc: Corey Minyard , qemu-devel@nongnu.org On 13/04/2015 18:34, Corey Minyard wrote: > > > I made this the same as the ACPI code, which you have to have as a > > > callback if you are adding it to a common SSDT. > > > > Not really I think. > > The AML functions require that you have a tree to attach what you are > adding. If you did your own SSDT, you wouldn't need a callback. You > could add a binary blob that gets put into the SSDT, but I think that > would require adding some AML functions. I very much prefer the callback idea. Long term it could be used by more devices and possibly it could be turned into an AMLProvider QOM interface. Then the ACPI builder could iterate on all QOM devices and just ask which of them can provide some AML. Also, tables are rebuilt when the firmware loads them, and handing in a blob makes it harder to achieve this on-the-fly modification, compared to callbacks. Paolo