From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhhQD-0002NA-1w for qemu-devel@nongnu.org; Mon, 13 Apr 2015 12:41:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhhQ9-0002bN-QZ for qemu-devel@nongnu.org; Mon, 13 Apr 2015 12:41:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41089) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhhQ9-0002b6-Ip for qemu-devel@nongnu.org; Mon, 13 Apr 2015 12:41:13 -0400 Message-ID: <552BF19E.4070206@redhat.com> Date: Mon, 13 Apr 2015 18:41:02 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1428436304-24044-1-git-send-email-minyard@acm.org> <1428436304-24044-15-git-send-email-minyard@acm.org> <20150412180834-mutt-send-email-mst@redhat.com> <552B1C45.1080304@acm.org> <552BC857.3040300@redhat.com> <552BE835.4080609@acm.org> In-Reply-To: <552BE835.4080609@acm.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: minyard@acm.org, "Michael S. Tsirkin" Cc: Corey Minyard , qemu-devel@nongnu.org On 13/04/2015 18:00, Corey Minyard wrote: > On 04/13/2015 08:44 AM, Paolo Bonzini wrote: >> >> On 13/04/2015 03:30, Corey Minyard wrote: >>>> Hmm, I don't see patch 15/15 so I don't know how this is used. >>> Yeah, I resent and I don't know what's happened. All the others were >>> sent exactly the same way. Something doesn't like that patch. >> Can you send that privately? Or put it somewhere on the web. > > Ok, attaching it. Hopefully it goes through this way. Ok, looks good apart that I'd prefer IPMI-specific stubs to SMBIOS/ACPI stubs or ifdef-fery. Also it would be nice to have a unit test like we have for PCI bridges. Paolo