From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32951) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhjmK-0004eP-In for qemu-devel@nongnu.org; Mon, 13 Apr 2015 15:12:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhjmG-0004ho-Vb for qemu-devel@nongnu.org; Mon, 13 Apr 2015 15:12:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhjmG-0004hR-Pw for qemu-devel@nongnu.org; Mon, 13 Apr 2015 15:12:12 -0400 Message-ID: <552C150A.70709@redhat.com> Date: Mon, 13 Apr 2015 13:12:10 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427995743-7865-1-git-send-email-armbru@redhat.com> <1427995743-7865-10-git-send-email-armbru@redhat.com> In-Reply-To: <1427995743-7865-10-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="M5c3XwNMGj5hd91P4U0wuX5VQhId1NxNU" Subject: Re: [Qemu-devel] [PATCH RFC 09/19] qapi: qapi-commands.py option --type is unused, drop it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, akong@redhat.com, berto@igalia.com, mdroth@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --M5c3XwNMGj5hd91P4U0wuX5VQhId1NxNU Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/02/2015 11:28 AM, Markus Armbruster wrote: > Anything but --type sync (which is the default) suppresses output > entirely, which makes no sense. >=20 > Dates back to the initial commit c17d990. Commit message says > "Currently only generators for synchronous qapi/qmp functions are > supported", so maybe output other than "synchronous qapi/qmp" was > planned at the time, to be selected with --type. >=20 > Should other kinds of output ever materialize, we can put the option > back. >=20 > Signed-off-by: Markus Armbruster > --- > scripts/qapi-commands.py | 66 +++++++++++++++++++++++-----------------= -------- > 1 file changed, 31 insertions(+), 35 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --M5c3XwNMGj5hd91P4U0wuX5VQhId1NxNU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVLBUKAAoJEKeha0olJ0NqXTIH/1jhjOmAuGxi4j8OVr4/0xlR Rgz+CgGDsy8dTxogX18cKpD1KkE+ir5gA2PTS48+SYtT5f9omvOABdPhbm53tfqr 4oJG12cesXZtpgr7NRQ7zMUkdbsP/rjT5keggX7ecph9NTbzV0dKrSkbWoEcv1XZ FTPREZZF69w38pq5oBanlHKdcaWt5U/iQWfT3t/mNgEC127MYgolPqFOe/zCVcoP 089DOW7IUBRUGx3ueQuuC62doNAxbZKwyGTeGUvd3N2GEKngARCU3OuaxfpP2I/T 6NND8cpEWNb7xNL7WDUbjWNpwCFhk/hHaYOx6q417YIuG6N26aJQXYLziSKdOs8= =j0jp -----END PGP SIGNATURE----- --M5c3XwNMGj5hd91P4U0wuX5VQhId1NxNU--