From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhzX8-0003EH-Rw for qemu-devel@nongnu.org; Tue, 14 Apr 2015 08:01:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhzX4-00065s-Ix for qemu-devel@nongnu.org; Tue, 14 Apr 2015 08:01:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40184) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhzX4-00065l-Ep for qemu-devel@nongnu.org; Tue, 14 Apr 2015 08:01:34 -0400 Message-ID: <552D019C.1070801@redhat.com> Date: Tue, 14 Apr 2015 06:01:32 -0600 From: Eric Blake MIME-Version: 1.0 References: <1428474011-30797-1-git-send-email-liang.z.li@intel.com> <1428474011-30797-13-git-send-email-liang.z.li@intel.com> <871tjun959.fsf@neno.neno> In-Reply-To: <871tjun959.fsf@neno.neno> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ULmqcIdOsFIJ85SvOqhsh6HaMK1L53twd" Subject: Re: [Qemu-devel] [v7 12/14] migration: Use an array instead of 3 parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com, Liang Li Cc: qemu-devel@nongnu.org, armbru@redhat.com, lcapitulino@redhat.com, Yang Zhang , amit.shah@redhat.com, dgilbert@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ULmqcIdOsFIJ85SvOqhsh6HaMK1L53twd Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/08/2015 05:37 AM, Juan Quintela wrote: > Liang Li wrote: >> Put the three parameters related to multiple thread (de)compression >> into an int array, and use an enum type to index the parameter. >> >> Signed-off-by: Liang Li >> Signed-off-by: Yang Zhang >=20 > Reviewed-by: Juan Quintela >=20 >=20 > BTW, for the libvirt people, what do you think about moving the other > parameters here, and make the other accessors deprecated? >=20 > I mean here: > - xbzrle_cache_size > -> get mbps > -> set/get migration_speed > -> get/set migration_downtime > -> autoconverge? >=20 > You get the idea. Setting multiple bits through one command is nicer. Libvirt will still have to keep the code for driving older qemu, but I'm not opposed to consolidation. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ULmqcIdOsFIJ85SvOqhsh6HaMK1L53twd Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVLQGcAAoJEKeha0olJ0Nqu1sH/26w7lZpYqV+9wqOBEg5LfJp txnRg/OLtiOS2U8eFU+CJH3A5Yh3eGemR2sh3SQUArzjP3h1DWisybZW+1FrydwE rxIpBTIGkPYHVUULBBhmQpljgllXczyIuke1I7Nl2iYDrbxylraLvTqzWeba7kqu 4VGNHFnfv328n2Gtn5G8y4pggoNMoVwTxBDKckpCI+HVjHfayRh3POTTRRhFA7cp N3Z/GCtehGtLfPUmFQ0iUQfoXPBJoIlLRpqRP1L2NXkE8qZ2cAh9X8d1CMMQATSX KfV6yAPxiM7Dr3KpZ/AC9H7BSvUKX33Hz+Kd6ee/q2lY6kZ5xWRGNcF+oTFmQVk= =h/ef -----END PGP SIGNATURE----- --ULmqcIdOsFIJ85SvOqhsh6HaMK1L53twd--