From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55081) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhzZK-0004gb-JJ for qemu-devel@nongnu.org; Tue, 14 Apr 2015 08:03:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhzZG-0006Vp-Ao for qemu-devel@nongnu.org; Tue, 14 Apr 2015 08:03:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53419) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhzZG-0006Ui-2v for qemu-devel@nongnu.org; Tue, 14 Apr 2015 08:03:50 -0400 Message-ID: <552D0224.7060001@redhat.com> Date: Tue, 14 Apr 2015 06:03:48 -0600 From: Eric Blake MIME-Version: 1.0 References: <1428474011-30797-1-git-send-email-liang.z.li@intel.com> <1428474011-30797-13-git-send-email-liang.z.li@intel.com> In-Reply-To: <1428474011-30797-13-git-send-email-liang.z.li@intel.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lhQCoenDPWVpjOHaADF53Dh3W8iPjHVq5" Subject: Re: [Qemu-devel] [v7 12/14] migration: Use an array instead of 3 parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liang Li , qemu-devel@nongnu.org Cc: quintela@redhat.com, armbru@redhat.com, lcapitulino@redhat.com, Yang Zhang , amit.shah@redhat.com, dgilbert@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lhQCoenDPWVpjOHaADF53Dh3W8iPjHVq5 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/08/2015 12:20 AM, Liang Li wrote: > Put the three parameters related to multiple thread (de)compression > into an int array, and use an enum type to index the parameter. >=20 > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > include/migration/migration.h | 4 +--- > migration/migration.c | 31 +++++++++++++++++++------------ > qapi-schema.json | 23 +++++++++++++++++++++++ > 3 files changed, 43 insertions(+), 15 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -569,6 +569,29 @@ > ## > { 'command': 'query-migrate-capabilities', 'returns': ['MigrationCap= abilityStatus']} > =20 > +# @MigrationParameter > +# > +# Migration parameters enumeration > +# > +# @compress-level: Set the compression level to be used in live migrat= ion, > +# the compression level is an integer between 0 and 9, where = 0 means > +# no compression, 1 means the best compression speed, and 9 m= eans best > +# compression ratio which will consume more CPU. > +# > +# @compress-threads: Set compression thread count to be used in live m= igration, > +# the compression thread count is an integer between 1 and 25= 5. > +# > +# @decompress-threads: Set decompression thread count to be used in li= ve > +# migration, the decompression thread count is an integer bet= ween 1 > +# and 255. Usually, decompression is at least 4 times as fast= as > +# compression, so set the decompress-threads to the number ab= out 1/4 > +# of compress-threads is adequate. s/so set/so setting/ > +# > +# Since: 2.3 2.4 Maintainer can fix if a respin is not needed. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lhQCoenDPWVpjOHaADF53Dh3W8iPjHVq5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVLQIkAAoJEKeha0olJ0NqE6AH/0Pr8v3Qr3H5nzMaCqQ5L49M BpPKXnQS+7WIWNhUle88TQKx6oz55MiZ/b5Vmazc9xP2qPHLe8KBJ/s32Jvc/G4c XY/pC4mgPatM+QWueUQplsD0fqBk5pTmZMGMHTsg1EfNNEtejATYx2vOHDdYz8Qk U7E8mRIozOxi2yZ0bOuyvZe1vdCK3PSen8OZoIIaY+ubhTkzzYK6SI3olfL0XU/l lJD+jMGNhg25wPXNYXk0XOpxbpaLUjpx1mfEAGDwC4bdqzmn4TBixPO2Ystm/kEU 6DKvujw0JzAZuIMGftjxl6fAbKxNFSgtwImvO8+S0/cRitd35h9gs0PKIMy2dfo= =qHig -----END PGP SIGNATURE----- --lhQCoenDPWVpjOHaADF53Dh3W8iPjHVq5--