Re: [Qemu-devel] [v7 13/14] migration: Add qmp commands to set and query parameters

[Eric Blake <eblake@redhat.com>]

On 04/14/2015 06:09 AM, Eric Blake wrote:
> On 04/08/2015 12:20 AM, Liang Li wrote:
>> Add the qmp commands to tune and query the parameters used in live
>> migration.
>>
>> Signed-off-by: Liang Li <liang.z.li@intel.com>
>> Signed-off-by: Yang Zhang <yang.z.zhang@intel.com>
>> ---
>>  migration/migration.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  qapi-schema.json      | 45 ++++++++++++++++++++++++++++++++++++++++
>>  qmp-commands.hx       | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++
>>  3 files changed, 158 insertions(+)

>> +    if (has_compress_level && (compress_level < 0 || compress_level > 9)) {
>> +        error_set(errp, QERR_INVALID_PARAMETER_VALUE, "compress_level",
>> +                  "is invalid, it should be in the range of 0 to 9");

All three error messages are bogus; this expands to:
"Parameter 'compress_level' expects is invalid, it should be in the
range of 0 to 9"


> Minor enough that I'm okay if the maintainer fixes the release number
> and adds:
> Reviewed-by: Eric Blake <eblake@redhat.com>

I'm no longer okay with this patch; you'll need a v8 that improves the
error wording (QERR_ macros are seldom the right thing to use, you may
be better off open-coding error_setg() and doing a sane message in place).

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org