From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhzlI-0001pV-0T for qemu-devel@nongnu.org; Tue, 14 Apr 2015 08:16:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YhzlA-00031o-Qk for qemu-devel@nongnu.org; Tue, 14 Apr 2015 08:16:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38878) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YhzlA-00031e-IL for qemu-devel@nongnu.org; Tue, 14 Apr 2015 08:16:08 -0400 Message-ID: <552D0504.9050605@redhat.com> Date: Tue, 14 Apr 2015 06:16:04 -0600 From: Eric Blake MIME-Version: 1.0 References: <1428474011-30797-1-git-send-email-liang.z.li@intel.com> <1428474011-30797-14-git-send-email-liang.z.li@intel.com> <552D038F.4020503@redhat.com> In-Reply-To: <552D038F.4020503@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [v7 13/14] migration: Add qmp commands to set and query parameters List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Liang Li , qemu-devel@nongnu.org Cc: quintela@redhat.com, armbru@redhat.com, lcapitulino@redhat.com, amit.shah@redhat.com, Yang Zhang , dgilbert@redhat.com On 04/14/2015 06:09 AM, Eric Blake wrote: > On 04/08/2015 12:20 AM, Liang Li wrote: >> Add the qmp commands to tune and query the parameters used in live >> migration. >> >> Signed-off-by: Liang Li >> Signed-off-by: Yang Zhang >> --- >> migration/migration.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++ >> qapi-schema.json | 45 ++++++++++++++++++++++++++++++++++++++++ >> qmp-commands.hx | 57 +++++++++++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 158 insertions(+) >> + if (has_compress_level && (compress_level < 0 || compress_level > 9)) { >> + error_set(errp, QERR_INVALID_PARAMETER_VALUE, "compress_level", >> + "is invalid, it should be in the range of 0 to 9"); All three error messages are bogus; this expands to: "Parameter 'compress_level' expects is invalid, it should be in the range of 0 to 9" > Minor enough that I'm okay if the maintainer fixes the release number > and adds: > Reviewed-by: Eric Blake I'm no longer okay with this patch; you'll need a v8 that improves the error wording (QERR_ macros are seldom the right thing to use, you may be better off open-coding error_setg() and doing a sane message in place). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org