From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34719) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yi1rk-0001U6-T5 for qemu-devel@nongnu.org; Tue, 14 Apr 2015 10:31:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yi1rf-0000Uc-Ay for qemu-devel@nongnu.org; Tue, 14 Apr 2015 10:31:04 -0400 Received: from mail-wi0-x230.google.com ([2a00:1450:400c:c05::230]:35945) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yi1rf-0000UJ-2s for qemu-devel@nongnu.org; Tue, 14 Apr 2015 10:30:59 -0400 Received: by wizk4 with SMTP id k4so116106333wiz.1 for ; Tue, 14 Apr 2015 07:30:58 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <552D249E.3000302@redhat.com> Date: Tue, 14 Apr 2015 16:30:54 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1428523369-13700-1-git-send-email-peter.maydell@linaro.org> <20150414153808.4a069d93@thh440s> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , Thomas Huth Cc: QEMU Developers , Michael Roth On 14/04/2015 15:41, Peter Maydell wrote: > No, this is not-for-2.3. I think that the issue here is that > merely adding -m32 isn't sufficient, because pkg-config when > run by configure will end up pointing at a bunch of incorrect > glib includes (for x86-64, not i386). So the actual solution > is to give configure the right pkg-config, and then gsize and > size_t are the same. There's a patch by John Snow for > configure on-list for that. Ah, that's reassuring. :) I was surprised by the timing and by Michael asking whether he should have posted a pull request. Paolo