From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33659) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yi3Mh-0007pG-RK for qemu-devel@nongnu.org; Tue, 14 Apr 2015 12:07:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yi3Md-00055A-Jb for qemu-devel@nongnu.org; Tue, 14 Apr 2015 12:07:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yi3Md-000553-CX for qemu-devel@nongnu.org; Tue, 14 Apr 2015 12:07:03 -0400 Message-ID: <552D3B24.4020803@redhat.com> Date: Tue, 14 Apr 2015 10:07:00 -0600 From: Eric Blake MIME-Version: 1.0 References: <1427994155-25043-1-git-send-email-marcandre.lureau@gmail.com> <1427994155-25043-4-git-send-email-marcandre.lureau@gmail.com> <20150414142507.GI4131@wheatley> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ksns8O9pPr7LXkI9WwdE8ovSkXLuabDp4" Subject: Re: [Qemu-devel] [libvirt] [PATCH 3/5] qemu: add QEMU_CAPS_MACHINE_VMPORT_OPT List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?TWFyYy1BbmRyw6kgTHVyZWF1?= , Martin Kletzander Cc: libvir-list@redhat.com, "qemu-devel@nongnu.org" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ksns8O9pPr7LXkI9WwdE8ovSkXLuabDp4 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable [adding qemu] On 04/14/2015 09:58 AM, Marc-Andr=C3=A9 Lureau wrote: > Hi >=20 > On Tue, Apr 14, 2015 at 4:25 PM, Martin Kletzander > wrote: >=20 >> Is this not exposed in any way in QEMU? Do we really need to use this= >> (what we're trying to avoid)? >> >=20 > That works with the following change: >=20 > diff --git a/src/qemu/qemu_capabilities.c b/src/qemu/qemu_capabilities.= c > index 768cef1..1b20a7f 100644 > --- a/src/qemu/qemu_capabilities.c > +++ b/src/qemu/qemu_capabilities.c > @@ -2510,6 +2510,7 @@ struct virQEMUCapsCommandLineProps { >=20 > static struct virQEMUCapsCommandLineProps virQEMUCapsCommandLine[] =3D= { > { "machine", "mem-merge", QEMU_CAPS_MEM_MERGE }, > + { "machine", "vmport", QEMU_CAPS_MACHINE_VMPORT_OPT }, Ouch. qemu commit 0a7cf21 fixes what would have been a regression in 2.3 at exposing "mem-merge" through query-command-line-options, but it does NOT expose "vmport", which is a per-architecture option rather than a generic -machine option. Which means that even though qemu 2.2 (perhaps wrongly) advertised "vmport" for all machines (even when it was not supported), 2.3 will not advertise it, and we are hoping for a better solution in 2.4 for properly advertising vmport on an as-appropriate basis. Yes, we WANT to use QMP probing,... > { "drive", "discard", QEMU_CAPS_DRIVE_DISCARD }, > { "realtime", "mlock", QEMU_CAPS_MLOCK }, > { "boot-opts", "strict", QEMU_CAPS_BOOT_STRICT }, > @@ -3243,10 +3244,6 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCap= s, > if (qemuCaps->version >=3D 1003000) > virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_USB_OPT); >=20 > - /* vmport option is supported v2.2.0 onwards */ > - if (qemuCaps->version >=3D 2002000) > - virQEMUCapsSet(qemuCaps, QEMU_CAPS_MACHINE_VMPORT_OPT); =2E..and not version comparison, but we'll need something better in QMP for 2.3 (which is rather late, since we missed 2.3-rc3) if you can't come up with anything better for learning whether vmport is supported. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Ksns8O9pPr7LXkI9WwdE8ovSkXLuabDp4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVLTskAAoJEKeha0olJ0Nq5KUH/A5iGl5AAT3j3iGSdJxxBkUr CycwxZe5YUhvc0G0/62Pl5KVVr1wh3UMmmjXISRdmez4R3/C/0ny+WpvMlVBWCfj mihPapJpWO8/Qx4cgw7RRku2A1rEwDKw2Ty1CgFbqCflpJl9vbL5Lt9P8UxbZM9D IyCr4RSD/9sAtXbu/YxcKz1tsU72sEAOPipgc/ACUGrosAMr7ArCLEo7PE+Dl+rW BK7dq5uMzn7/WioI2Toq/chHmFrJtOvblnXF5/UurmMARMwEX40OQJMTP9Dz7jef 5iNVE41KZUTantNpvyy2NkhvqLwu34065e7TRbspa3i0gFY5VTuz7+m/X5+/UmU= =QxGs -----END PGP SIGNATURE----- --Ksns8O9pPr7LXkI9WwdE8ovSkXLuabDp4--