From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56431) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiO7k-0007T4-8t for qemu-devel@nongnu.org; Wed, 15 Apr 2015 10:17:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YiO7e-0005hl-Ny for qemu-devel@nongnu.org; Wed, 15 Apr 2015 10:17:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiO7e-0005he-J0 for qemu-devel@nongnu.org; Wed, 15 Apr 2015 10:16:58 -0400 Message-ID: <552E72D2.8080405@redhat.com> Date: Wed, 15 Apr 2015 16:16:50 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1428934370-29695-1-git-send-email-liang.z.li@intel.com> <552BD273.9060105@redhat.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] xen-pt: Fix bug cause PCI devices re-attach failed List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Li, Liang Z" , "qemu-devel@nongnu.org" Cc: "peter.crosthwaite@xilinx.com" , "xen-devel@lists.xensource.com" , "stefano.stabellini@eu.citrix.com" , "Tian, Kevin" , "Zhang, Yang Z" , "Hu, Robert" On 15/04/2015 16:14, Li, Liang Z wrote: > Yes, it's the right place. Put aside the bug fix, I think the memory_region_ref/unref pair > should be move to xen_pt_region_update after the conditional as you point out. > Do you think so? It would make sense, but I was just guessing... I'm still not sure whether that causes any difference, also because I'm not familiar with the Xen PCI passthrough code. Paolo