From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YiPGD-0007cZ-Du for qemu-devel@nongnu.org; Wed, 15 Apr 2015 11:29:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YiPGC-0003yM-P2 for qemu-devel@nongnu.org; Wed, 15 Apr 2015 11:29:53 -0400 Message-ID: <552E83E9.70901@redhat.com> Date: Wed, 15 Apr 2015 17:29:45 +0200 From: Max Reitz MIME-Version: 1.0 References: <9d3f6d8991748d16f4e56de6d7f62f6618dea936.1428503789.git.berto@igalia.com> In-Reply-To: <9d3f6d8991748d16f4e56de6d7f62f6618dea936.1428503789.git.berto@igalia.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 3/6] block: never cancel a streaming job without running stream_complete() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Stefan Hajnoczi , qemu-block@nongnu.org On 08.04.2015 16:43, Alberto Garcia wrote: > We need to call stream_complete() in order to do all the necessary > clean-ups, even if there's an early failure. At the moment it's only > useful to make sure that s->backing_file_str is not leaked, Which is important enough on its own. > but it > will become more important as we introduce support for streaming to > any intermediate node. > > Signed-off-by: Alberto Garcia > --- > block/stream.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) Reviewed-by: Max Reitz