From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yijj4-0004Vm-Ti for qemu-devel@nongnu.org; Thu, 16 Apr 2015 09:21:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yijj1-0002Fa-Jt for qemu-devel@nongnu.org; Thu, 16 Apr 2015 09:21:02 -0400 Message-ID: <552FB725.7020905@redhat.com> Date: Thu, 16 Apr 2015 15:20:37 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1429186730-3866-1-git-send-email-pl@kamp.de> <1429186730-3866-8-git-send-email-pl@kamp.de> <552FAC28.80403@redhat.com> <552FB1EC.5070606@kamp.de> In-Reply-To: <552FB1EC.5070606@kamp.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.4 07/10] block/iscsi: bump libiscsi requirement to 1.10.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Lieven , qemu-devel@nongnu.org Cc: ronniesahlberg@gmail.com, qemu-block@nongnu.org On 16/04/2015 14:58, Peter Lieven wrote: >> >> On 16/04/2015 14:18, Peter Lieven wrote: >>> We need this to support SCSI_STATUS_TASK_SET_FULL. >> Any reason apart from the missing constant? > > No, but I wanted to avoid starting checking for constants that were > added shortly after this. > You can't check with #ifdef for a constant in an enum. But you can #define it if libiscsi version is <1.10. > Libiscsi 1.10 was released in September 2013. But RHEL7 only has libiscsi 1.9 for example (it froze in August 2013), and it won't upgrade ever due to ABI breakage in libiscsi. Paolo