From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YimdN-0002ZT-FD for qemu-devel@nongnu.org; Thu, 16 Apr 2015 12:27:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YimdK-0004Jl-D4 for qemu-devel@nongnu.org; Thu, 16 Apr 2015 12:27:21 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:36510) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YimdK-0004JH-8A for qemu-devel@nongnu.org; Thu, 16 Apr 2015 12:27:18 -0400 Received: by pdea3 with SMTP id a3so97333741pde.3 for ; Thu, 16 Apr 2015 09:27:16 -0700 (PDT) Message-ID: <552FE2DD.2000600@ozlabs.ru> Date: Fri, 17 Apr 2015 02:27:09 +1000 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1428679484-15451-1-git-send-email-aik@ozlabs.ru> <1428679484-15451-5-git-send-email-aik@ozlabs.ru> <20150416095045.754f5434@thh440s> In-Reply-To: <20150416095045.754f5434@thh440s> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH qemu v6 04/15] vfio: spapr: Move SPAPR-related code to a separate file List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth Cc: Michael Roth , Alexander Graf , qemu-devel@nongnu.org, Alex Williamson , qemu-ppc@nongnu.org, Gavin Shan , David Gibson On 04/16/2015 05:50 PM, Thomas Huth wrote: > Am Sat, 11 Apr 2015 01:24:33 +1000 > schrieb Alexey Kardashevskiy : > >> This moves SPAPR bits to a separate file to avoid pollution of x86 code. >> >> This is a mechanical patch. >> >> Signed-off-by: Alexey Kardashevskiy >> Reviewed-by: David Gibson >> --- >> hw/vfio/Makefile.objs | 1 + >> hw/vfio/common.c | 134 ++----------------------- >> hw/vfio/spapr.c | 226 ++++++++++++++++++++++++++++++++++++++++++ >> include/hw/vfio/vfio-common.h | 13 +++ >> 4 files changed, 246 insertions(+), 128 deletions(-) >> create mode 100644 hw/vfio/spapr.c >> >> diff --git a/hw/vfio/Makefile.objs b/hw/vfio/Makefile.objs >> index e31f30e..b987ffb 100644 >> --- a/hw/vfio/Makefile.objs >> +++ b/hw/vfio/Makefile.objs >> @@ -1,4 +1,5 @@ >> ifeq ($(CONFIG_LINUX), y) >> obj-$(CONFIG_SOFTMMU) += common.o >> obj-$(CONFIG_PCI) += pci.o >> +obj-$(CONFIG_SOFTMMU) += spapr.o > > Would it be possible / make sense to use CONFIG_PSERIES instead of > CONFIG_SOFTMMU here instead? No. This file has some exports and CONFIG_PSERIES is only for makefiles, the source code does not get to see these config options so it is impossible to define extern symbols and stubs. -- Alexey