From: Claudio Fontana <cfontana@suse.de>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Laurent Vivier <laurent@vivier.eu>,
kvm@vger.kernel.org
Subject: Re: [PATCH 2/3] accel/stubs: Restrict system-mode emulation stubs
Date: Mon, 9 Nov 2020 10:56:28 +0100 [thread overview]
Message-ID: <552db7b0-78da-7f5c-065f-c82b6a296852@suse.de> (raw)
In-Reply-To: <20201109094547.2456385-3-f4bug@amsat.org>
On 11/9/20 10:45 AM, Philippe Mathieu-Daudé wrote:
> This system-mode emulation stubs are not require
nit: s,require,required,
> in user-mode binaries. Restrict them to system-mode
> binaries.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> accel/stubs/meson.build | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
> diff --git a/accel/stubs/meson.build b/accel/stubs/meson.build
> index 12dd1539afa..a83408bc0a7 100644
> --- a/accel/stubs/meson.build
> +++ b/accel/stubs/meson.build
> @@ -1,4 +1,8 @@
> -specific_ss.add(when: 'CONFIG_HAX', if_false: files('hax-stub.c'))
> -specific_ss.add(when: 'CONFIG_XEN', if_false: files('xen-stub.c'))
> -specific_ss.add(when: 'CONFIG_KVM', if_false: files('kvm-stub.c'))
> -specific_ss.add(when: 'CONFIG_TCG', if_false: files('tcg-stub.c'))
> +accel_stubs_ss = ss.source_set()
> +
> +accel_stubs_ss.add(when: 'CONFIG_HAX', if_false: files('hax-stub.c'))
> +accel_stubs_ss.add(when: 'CONFIG_XEN', if_false: files('xen-stub.c'))
> +accel_stubs_ss.add(when: 'CONFIG_KVM', if_false: files('kvm-stub.c'))
> +accel_stubs_ss.add(when: 'CONFIG_TCG', if_false: files('tcg-stub.c'))
> +
> +specific_ss.add_all(when: ['CONFIG_SOFTMMU'], if_true: accel_stubs_ss)
>
next prev parent reply other threads:[~2020-11-09 9:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 9:45 [PATCH 0/3] accel: Remove system-mode stubs from user-mode builds Philippe Mathieu-Daudé
2020-11-09 9:45 ` [PATCH 1/3] accel: Only include TCG stubs in user-mode only builds Philippe Mathieu-Daudé
2020-11-09 9:55 ` Claudio Fontana
2020-11-09 10:48 ` Paolo Bonzini
2020-11-09 9:45 ` [PATCH 2/3] accel/stubs: Restrict system-mode emulation stubs Philippe Mathieu-Daudé
2020-11-09 9:56 ` Claudio Fontana [this message]
2020-11-09 9:45 ` [PATCH 3/3] accel/stubs: Simplify kvm-stub.c Philippe Mathieu-Daudé
2020-11-09 10:50 ` [PATCH 0/3] accel: Remove system-mode stubs from user-mode builds Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552db7b0-78da-7f5c-065f-c82b6a296852@suse.de \
--to=cfontana@suse.de \
--cc=f4bug@amsat.org \
--cc=kvm@vger.kernel.org \
--cc=laurent@vivier.eu \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).