From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46628) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj0UU-0004Mk-Vj for qemu-devel@nongnu.org; Fri, 17 Apr 2015 03:15:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj0UR-0006Vv-8H for qemu-devel@nongnu.org; Fri, 17 Apr 2015 03:15:06 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:48056 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj0UQ-0006S3-R1 for qemu-devel@nongnu.org; Fri, 17 Apr 2015 03:15:03 -0400 Message-ID: <5530B2F2.7040907@kamp.de> Date: Fri, 17 Apr 2015 09:14:58 +0200 From: Peter Lieven MIME-Version: 1.0 References: <1429186730-3866-1-git-send-email-pl@kamp.de> <1429186730-3866-6-git-send-email-pl@kamp.de> <552FAE53.7050102@redhat.com> <552FB2DD.9010902@kamp.de> <552FB652.4040400@redhat.com> In-Reply-To: <552FB652.4040400@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.4 05/10] block/iscsi: optimize WRITE10/16 if cache.writeback is not set List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: ronniesahlberg@gmail.com, qemu-block@nongnu.org Am 16.04.2015 um 15:17 schrieb Paolo Bonzini: > > On 16/04/2015 15:02, Peter Lieven wrote: >>> Also, I think it is iscsi_co_generic_cb that should set >>> force_next_flush, so that it is only set on failure. Not really for the >>> optimization value, but because it's clearer. >> I don't get what you mean with it should only "set on failure". >> My approach would be to add a flag to the iTask that the command >> requires to set force_flush after successful completion. Is it that >> what you mean? > Set on success. Lack of sleep. I have send a v2 following your suggestions. Peter