From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43603) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj475-0000a0-Cp for qemu-devel@nongnu.org; Fri, 17 Apr 2015 07:07:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj472-00019n-JJ for qemu-devel@nongnu.org; Fri, 17 Apr 2015 07:07:11 -0400 Message-ID: <5530E955.60506@imgtec.com> Date: Fri, 17 Apr 2015 12:07:01 +0100 From: Leon Alrae MIME-Version: 1.0 References: <1429263996-928-1-git-send-email-leon.alrae@imgtec.com> <1429263996-928-2-git-send-email-leon.alrae@imgtec.com> <5530E540.2060007@imgtec.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 1/1] mips: fix broken fulong2e machine List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , QEMU Developers , qemu-stable On 17/04/2015 11:58, Peter Maydell wrote: > On 17 April 2015 at 11:49, Leon Alrae wrote: >> On 17/04/2015 11:42, Peter Maydell wrote: >>> On 17 April 2015 at 10:46, Leon Alrae wrote: >>>> After commit 5312bd8 the bonito_readl() and bonito_writel() have been >>>> accessing incorrect addresses. Consequently QEMU is crashing when trying >>>> to boot Linux kernel on fulong2e machine. >>>> >>>> Cc: qemu-stable@nongnu.org >>>> Signed-off-by: Paolo Bonzini >>>> Signed-off-by: Leon Alrae >>> >>> This is Paolo's patch, right? (it has his signoff). It >>> should have him as the author as well, but you seem to have >>> lost that... >> >> Well, I asked Paolo if he wanted to send the patch, but he suggested to >> send the pull request by myself and just put his Signed-off-by line. > > It's fine for you to send the patch, but you need to send it with > a From line in the commit message from him, not you. OK, I'll correct it. I'm hoping Paolo is happy with the commit message as I presume he will be blamed if there are any typos there :) Leon