From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 4/6] block: Support streaming to an intermediate layer
Date: Fri, 17 Apr 2015 14:46:25 +0200 [thread overview]
Message-ID: <553100A1.2070007@redhat.com> (raw)
In-Reply-To: <w51fv80ywku.fsf@maestria.local.igalia.com>
On 16.04.2015 16:30, Alberto Garcia wrote:
> On Wed 15 Apr 2015 06:09:18 PM CEST, Max Reitz <mreitz@redhat.com> wrote:
>
>>> + orig_bs_flags = bdrv_get_flags(bs);
>>> + if (!(orig_bs_flags & BDRV_O_RDWR)) {
>> I feel like we don't want to do this if we're not streaming to an
>> intermediate layer but to the top layer (because that means there is
>> some reason for the BDS to be read-only beyond it just being a backing
>> BDS).
> Looks like we don't actually need to do anything, bdrv_reopen_prepare()
> already takes care of checking the BDRV_O_ALLOW_RDWR flag, which is not
> set if the image was opened in read-only mode.
Oh, that's nice. :-)
Max
next prev parent reply other threads:[~2015-04-17 12:46 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-08 14:43 [Qemu-devel] [PATCH v3 0/6] Support streaming to an intermediate layer Alberto Garcia
2015-04-08 14:43 ` [Qemu-devel] [PATCH 1/6] block: keep a list of block jobs Alberto Garcia
2015-04-15 14:29 ` [Qemu-devel] [Qemu-block] " Max Reitz
2015-04-08 14:43 ` [Qemu-devel] [PATCH 2/6] block: allow block jobs in any arbitrary node Alberto Garcia
2015-04-15 15:22 ` [Qemu-devel] [Qemu-block] " Max Reitz
2015-04-16 8:20 ` Alberto Garcia
2015-04-08 14:43 ` [Qemu-devel] [PATCH 3/6] block: never cancel a streaming job without running stream_complete() Alberto Garcia
2015-04-15 15:29 ` [Qemu-devel] [Qemu-block] " Max Reitz
2015-04-08 14:43 ` [Qemu-devel] [PATCH 4/6] block: Support streaming to an intermediate layer Alberto Garcia
2015-04-15 16:09 ` [Qemu-devel] [Qemu-block] " Max Reitz
2015-04-16 9:36 ` Alberto Garcia
2015-04-16 12:27 ` Eric Blake
2015-04-16 12:34 ` Alberto Garcia
2015-04-17 8:02 ` Kevin Wolf
2015-04-16 14:30 ` Alberto Garcia
2015-04-17 12:46 ` Max Reitz [this message]
2015-04-08 14:43 ` [Qemu-devel] [PATCH 5/6] block: Add QMP support for " Alberto Garcia
2015-04-15 16:17 ` [Qemu-devel] [Qemu-block] " Max Reitz
2015-04-08 14:43 ` [Qemu-devel] [PATCH 6/6] docs: Document how to stream " Alberto Garcia
2015-04-15 16:25 ` [Qemu-devel] [Qemu-block] " Max Reitz
2015-04-15 16:27 ` [Qemu-devel] [Qemu-block] [PATCH v3 0/6] Support streaming " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553100A1.2070007@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).