From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj6iW-0008EU-69 for qemu-devel@nongnu.org; Fri, 17 Apr 2015 09:54:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj6iS-0007Oa-TV for qemu-devel@nongnu.org; Fri, 17 Apr 2015 09:54:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48486) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj6iS-0007OU-OG for qemu-devel@nongnu.org; Fri, 17 Apr 2015 09:53:56 -0400 Message-ID: <55311072.2070900@redhat.com> Date: Fri, 17 Apr 2015 07:53:54 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1CaKru48r8GVRhVGPjR8VCwOEK9phppD1" Subject: Re: [Qemu-devel] [PATCH RFC 1/3] memory: Add dump-pc-mem command for checkpointing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bohdan Trach , qemu-devel@nongnu.org Cc: Bohdan Trach , amit.shah@redhat.com, thomas.knauth@googlemail.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1CaKru48r8GVRhVGPjR8VCwOEK9phppD1 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/17/2015 06:13 AM, Bohdan Trach wrote: > From: Bohdan Trach >=20 > dump-pc-mem command is added for checkpointing guest memory to > file. Only system RAM region is saved. This checkpoint is later used to= > recover unchanged pages. >=20 > Signed-off-by: Bohdan Trach > --- >=20 > +void qmp_dump_pc_ram(const char *file, Error **errp) { > + > + int rc; > + int fd; > + fd =3D open(file, Please use qemu_open() rather than raw open(), so that your command automatically supports /dev/fdset/nnn notation for reusing a file descriptor passed in via SCM_RIGHTS. > +++ b/qapi-schema.json > @@ -3648,3 +3648,14 @@ > # Since: 2.1 > ## > { 'command': 'rtc-reset-reinjection' } > + > +## > +# @dump-pc-ram: > +# > +# Checkpoints guest. The whole guest, or just guest memory? > +# > +# @file: the file to save the memory to as binary data > +# > +# Returns: Nothing on success Missing a 'Since: 2.4' designation. > +## > +{ 'command': 'dump-pc-ram', 'data': {'file': 'str'} } --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1CaKru48r8GVRhVGPjR8VCwOEK9phppD1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVMRByAAoJEKeha0olJ0NqbAIH/j0KJzjSBkKq8RhBmBZ8uPSV VakcRjwwfvvtLqH0U4IPmSiqFu3EYmcpeW6UB5FTlSRR026DlObCH1fuzcl2guhv QzZFKop4hkWRofyoKIUozZGsJ++F7j7c7dt1b+lmykDzq/5EotZJy18wucPfdp4X ytvPRMn/6D0IOz2pQCXP7j5P0Lgb2eDEdqK41qG7Z3wo9sHIkFDyADKi5PxMtad8 6iFvYXapRQJu02Aaxv3qzepGmaAqAjNGO/JJ0xgWTCzL3Q8zix3wxwMClJWHCXpA 80iU32a9gri5SAjhTqcFyqzlb7SHZXVAFUSLkqIsW0dG+oZx2uWP5VRfRsFDDE8= =eryy -----END PGP SIGNATURE----- --1CaKru48r8GVRhVGPjR8VCwOEK9phppD1--