From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj7cS-0006r5-Du for qemu-devel@nongnu.org; Fri, 17 Apr 2015 10:51:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj7cM-0005gO-3s for qemu-devel@nongnu.org; Fri, 17 Apr 2015 10:51:48 -0400 Message-ID: <55311DF8.7020709@redhat.com> Date: Fri, 17 Apr 2015 16:51:36 +0200 From: Max Reitz MIME-Version: 1.0 References: <1427484005-31120-1-git-send-email-jsnow@redhat.com> <1427484005-31120-4-git-send-email-jsnow@redhat.com> In-Reply-To: <1427484005-31120-4-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 03/11] block: rename BlkTransactionState and BdrvActionOps List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, vsementsov@parallels.com, stefanha@redhat.com On 27.03.2015 20:19, John Snow wrote: > These structures are misnomers, somewhat. > > (1) BlockTransactionState is not state for a transaction, > but is rather state for a single transaction action. > Rename it "BlkActionState" to be more accurate. > > (2) The BdrvActionOps describes operations for the BlkActionState, > above. This name might imply a 'BdrvAction' or a 'BdrvActionState', > which there isn't. > Rename this to 'BlkActionOps' to match 'BlkActionState'. > > Lastly, update the surrounding in-line documentation and comments > to reflect the current nature of how Transactions operate. > > This patch changes only comments and names, and should not affect > behavior in any way. > > Signed-off-by: John Snow > --- > blockdev.c | 114 ++++++++++++++++++++++++++++++++++--------------------------- > 1 file changed, 64 insertions(+), 50 deletions(-) Reviewed-by: Max Reitz