From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj7en-0001Io-3Q for qemu-devel@nongnu.org; Fri, 17 Apr 2015 10:54:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj7em-0006k6-28 for qemu-devel@nongnu.org; Fri, 17 Apr 2015 10:54:13 -0400 Message-ID: <55311E8C.20404@redhat.com> Date: Fri, 17 Apr 2015 08:54:04 -0600 From: Eric Blake MIME-Version: 1.0 References: <1428531604-9428-1-git-send-email-jsnow@redhat.com> <1428531604-9428-5-git-send-email-jsnow@redhat.com> In-Reply-To: <1428531604-9428-5-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="lmUTcuWt6IssV0PJQr15cElCB1MO1bXb6" Subject: Re: [Qemu-devel] [PATCH v5 04/21] qmp: Add block-dirty-bitmap-add and block-dirty-bitmap-remove List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --lmUTcuWt6IssV0PJQr15cElCB1MO1bXb6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/08/2015 04:19 PM, John Snow wrote: > The new command pair is added to manage a user created dirty bitmap. Th= e > dirty bitmap's name is mandatory and must be unique for the same device= , > but different devices can have bitmaps with the same names. >=20 > The granularity is an optional field. If it is not specified, we will > choose a default granularity based on the cluster size if available, > clamped to between 4K and 64K to mirror how the 'mirror' code was > already choosing granularity. If we do not have cluster size info > available, we choose 64K. This code has been factored out into a helper= > shared with block/mirror. >=20 > This patch also introduces the 'block_dirty_bitmap_lookup' helper, > which takes a device name and a dirty bitmap name and validates the > lookup, returning NULL and setting errp if there is a problem with > either field. This helper will be re-used in future patches in this > series. >=20 > The types added to block-core.json will be re-used in future patches > in this series, see: > 'qapi: Add transaction support to block-dirty-bitmap-{add, enable, disa= ble}' >=20 > Signed-off-by: John Snow > Reviewed-by: Max Reitz > Reviewed-by: Stefan Hajnoczi > --- > block.c | 20 +++++++++ > block/mirror.c | 10 +---- > blockdev.c | 117 ++++++++++++++++++++++++++++++++++++++++++= ++++++++ > include/block/block.h | 1 + > qapi/block-core.json | 55 ++++++++++++++++++++++++ > qmp-commands.hx | 56 ++++++++++++++++++++++++ > 6 files changed, 250 insertions(+), 9 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --lmUTcuWt6IssV0PJQr15cElCB1MO1bXb6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVMR6MAAoJEKeha0olJ0NqVlgH/19UR/IR2Ebrm0q/Hs+kM56X 8VB/+ZxabCdWLxzUTEtsC2+LGCzpRVM+9Zj90oK3G0KJ+4rxo8sCpSa2biG+qE9E j2g3D7xXY4NNQHKAuZl1Yjvda3bPyk/dk0U8vdKB4GgQksPHoxzHXDmknpS5P3eN DqN7sAREj8E7P5Z6Phcgoc/bEo84XThrd+FzomilAej8LM3Ley8FvwdXB3O6qHcG k6dTmarP2Tn6JRUKYqF+7iMNhjIUojjnvR5+QSo02FiX8Y6A9FolItp2ZVbYKbgH pjc0tGzKqwksF+J6VWylwxZhrNB+/ZSlWEQWNQwZtV6hNBMZVlBxaoWdk3C4Fn0= =P4tU -----END PGP SIGNATURE----- --lmUTcuWt6IssV0PJQr15cElCB1MO1bXb6--