From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj83Q-0006yM-Mc for qemu-devel@nongnu.org; Fri, 17 Apr 2015 11:19:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj83N-0007cj-F3 for qemu-devel@nongnu.org; Fri, 17 Apr 2015 11:19:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38765) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj83N-0007cF-9K for qemu-devel@nongnu.org; Fri, 17 Apr 2015 11:19:37 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 0396DAB110 for ; Fri, 17 Apr 2015 15:19:37 +0000 (UTC) Message-ID: <55312483.50500@redhat.com> Date: Fri, 17 Apr 2015 17:19:31 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1429280557-8887-1-git-send-email-berrange@redhat.com> <1429280557-8887-7-git-send-email-berrange@redhat.com> <55311F3B.8060305@redhat.com> <55312044.90604@redhat.com> <20150417151140.GG23619@redhat.com> In-Reply-To: <20150417151140.GG23619@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v1 RFC 06/34] qom: add a object_property_add_enum helper method List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Gerd Hoffmann On 17/04/2015 17:11, Daniel P. Berrange wrote: > > On second thought (after seeing patch 7), please add a property type > > argument here. We lose introspection of enum property types otherwise. > > Can you give me a pointer to where we lose introspection ? The hostmem > code just registers its 'policy' property with a type name of 'str', That was already a bug. :( It should have been registered as "HostMemPolicy". See for example: $ qemu-system-x86_64 -device ide-hd,help ide-hd.bootindex=int32 ide-hd.unit=uint32 ide-hd.bios-chs-trans=BiosAtaTranslation (Logical CHS translation algorithm, auto/none/lba/large/rechs) ... > which I've just changed to 'enum' in patch 7, so I didn't think I was > regressing anything. Is there some QMP command which you think looses > the info that I can verify. The qom-list command returns a list of property names and types. Paolo