From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj8dC-0004MA-Ng for qemu-devel@nongnu.org; Fri, 17 Apr 2015 11:56:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj8d8-00069E-Jg for qemu-devel@nongnu.org; Fri, 17 Apr 2015 11:56:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39993) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj8d8-00069A-Bn for qemu-devel@nongnu.org; Fri, 17 Apr 2015 11:56:34 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3HFuX5N026224 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Fri, 17 Apr 2015 11:56:33 -0400 Message-ID: <55312D30.2000406@redhat.com> Date: Fri, 17 Apr 2015 09:56:32 -0600 From: Eric Blake MIME-Version: 1.0 References: <1429280557-8887-1-git-send-email-berrange@redhat.com> <1429280557-8887-2-git-send-email-berrange@redhat.com> In-Reply-To: <1429280557-8887-2-git-send-email-berrange@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="asQntu6rEdxiCc8OX4QgX4LHClK3RSVb8" Subject: Re: [Qemu-devel] [PATCH v1 RFC 01/34] ui: remove check for failure of qemu_acl_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Cc: Paolo Bonzini , Gerd Hoffmann , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --asQntu6rEdxiCc8OX4QgX4LHClK3RSVb8 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/17/2015 08:22 AM, Daniel P. Berrange wrote: > The qemu_acl_init() function has long since stopped being able > to return NULL, since g_malloc will abort on OOM. As such the > checks for NULL were unreachable code. >=20 > Signed-off-by: Daniel P. Berrange > --- > ui/vnc.c | 8 -------- > 1 file changed, 8 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --asQntu6rEdxiCc8OX4QgX4LHClK3RSVb8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVMS0wAAoJEKeha0olJ0NqyuAH/Rcn2HuI9MMfJBlr5MHzP+1R xHqrNrhFKO/lu9+CeV0LxUovWJdZ3u+f7pg7dnk900jfJy7Hg65j6RtCueBK28st vCieb6S1UL3hhxS+llE5FfMbF9Oy61aTdpT3WmhQ1RuAaz//9C6psISh+LHXBqki se1k1bvsMiQ7stuo9Ipw6tD6BZTqfg1RqN0lowPae0c5yo6u3rcT0izI3Djy3Irg eRkFdQ3zTY6E86LSmrZO+m8VdRFKnGo586C1BnQ8grVvOF2w+PWb1VWIxKrTQ5IB K2ddXdicyzZwJRkcBsavzlWXp2SoO1fIpGgU3lyzImVMAn2XpNG/BZhi6pZV9s8= =CPdc -----END PGP SIGNATURE----- --asQntu6rEdxiCc8OX4QgX4LHClK3RSVb8--