From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37009) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj8se-00066v-NB for qemu-devel@nongnu.org; Fri, 17 Apr 2015 12:12:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj8sb-0003x9-Gr for qemu-devel@nongnu.org; Fri, 17 Apr 2015 12:12:36 -0400 Message-ID: <553130EC.7040902@redhat.com> Date: Fri, 17 Apr 2015 18:12:28 +0200 From: Max Reitz MIME-Version: 1.0 References: <1427484005-31120-1-git-send-email-jsnow@redhat.com> <1427484005-31120-10-git-send-email-jsnow@redhat.com> In-Reply-To: <1427484005-31120-10-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 09/11] qmp: Add an implementation wrapper for qmp_drive_backup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, vsementsov@parallels.com, stefanha@redhat.com On 27.03.2015 20:20, John Snow wrote: > We'd like to be able to specify the callback given to backup_start > manually in the case of transactions, so split apart qmp_drive_backup > into an implementation and a wrapper. > > Switch drive_backup_prepare to use the new wrapper, but don't overload > the callback and closure yet. > > Signed-off-by: John Snow > --- > blockdev.c | 65 ++++++++++++++++++++++++++++++++++++++++++++------------------ > 1 file changed, 46 insertions(+), 19 deletions(-) Reviewed-by: Max Reitz The problem being that it relies on patch 8. I don't think being able to avoid a single forward declaration warrants moving half (or more...) of blockdev.c around, but I'm open to be convinced otherwise. Max