From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yj9Z4-0001hA-Rv for qemu-devel@nongnu.org; Fri, 17 Apr 2015 12:56:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yj9Z0-0002JX-Ry for qemu-devel@nongnu.org; Fri, 17 Apr 2015 12:56:26 -0400 Message-ID: <55313B34.1030602@redhat.com> Date: Fri, 17 Apr 2015 12:56:20 -0400 From: John Snow MIME-Version: 1.0 References: <1428531604-9428-1-git-send-email-jsnow@redhat.com> <1428531604-9428-20-git-send-email-jsnow@redhat.com> <553119A8.9040309@redhat.com> In-Reply-To: <553119A8.9040309@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 19/21] iotests: add simple incremental backup case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com On 04/17/2015 10:33 AM, Max Reitz wrote: > On 09.04.2015 00:20, John Snow wrote: >> Signed-off-by: John Snow >> --- >> tests/qemu-iotests/124 | 174 >> +++++++++++++++++++++++++++++++++++++++++++-- >> tests/qemu-iotests/124.out | 4 +- >> 2 files changed, 172 insertions(+), 6 deletions(-) > > I was happier with the previous simpler approach, but I guess I'll have > to get my happiness somewhere else today. > > Reviewed-by: Max Reitz > I was much happier with that approach as well. I would actually still prefer to roll back the tests to the earlier version if at all possible and use the simple "check as we go" mechanism.