From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yjsv0-0004SW-OD for qemu-devel@nongnu.org; Sun, 19 Apr 2015 13:22:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yjsuv-0007My-PR for qemu-devel@nongnu.org; Sun, 19 Apr 2015 13:22:06 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38057 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yjsuv-0007MT-It for qemu-devel@nongnu.org; Sun, 19 Apr 2015 13:22:01 -0400 Message-ID: <5533E437.70108@suse.de> Date: Sun, 19 Apr 2015 19:21:59 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1429440741-48575-1-git-send-email-itamar@guardicore.com> <1429440741-48575-2-git-send-email-itamar@guardicore.com> <5533CE0D.4020807@suse.de> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v02] add 1394 bus support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Itamar Tal Cc: thuth@redhat.com, ariel@guardicore.com, Itamar Tal , qemu-devel@nongnu.org Hi, Am 19.04.2015 um 18:38 schrieb Itamar Tal: > I've set it just after the subject field in the patch? Should I add it > somewhere else and resubmit? Please compare other QEMU or Linux patches: It needs to go before --- into the commit message. git commit --amend -s will place it correctly. BTW I'm missing a type_init() and type_register_static() in the bottom of hcd-ohci.c and wonder how you managed to test it without. Did you copy this code from some other codebase? For one, hcd-ohci.c has "address@hidden", which looks like you copied it from some mailing list archive (then you need to replicate those authors' Signed-off-bys), and for another the Coding Style does not exactly match that of QEMU, in particular you are using a lot of custom _t types whereas QEMU uses CamelCase type names. BTW if you consistently used typedefs for your unions, you could avoid those macros declaring phy etc. unions inline, no= ? Please also drop the empty last line in the new files you add. Did you run scripts/checkpatch.pl? Running git-am on a clean branch can also help highlight whitespace errors. hcd-ohci.h is missing a license/copyright header. hcd_pci_exit() has commented-out code - please fix or remove. hcd_pci_init() has the opening brace placed wrong. It looks like a generic PCI device, so why are you placing the config option into i386 and x86_64 configs only rather than pci.mak? Regards, Andreas P.S. Please don't top-post. > On Apr 19, 2015 6:47 PM, "Andreas F=C3=A4rber" > wrote: >=20 > Am 19.04.2015 um 12:52 schrieb itamar.tal4@gmail.com > : > > From: Itamar Tal > > > > > --- >=20 > Still no Signed-off-by... >=20 > Regards, > Andreas >=20 > -- > SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany > GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Up= manyu, > Graham Norton; HRB 21284 (AG N=C3=BCrnberg) >=20 --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Felix Imend=C3=B6rffer, Jane Smithard, Jennifer Guild, Dilip Upmanyu, Graham Norton; HRB 21284 (AG N=C3=BCrnberg)