qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Leon Alrae <leon.alrae@imgtec.com>
To: Peter Maydell <peter.maydell@linaro.org>, Liviu Ionescu <ilg@livius.net>
Cc: "christopher.covington@linaro.org"
	<christopher.covington@linaro.org>,
	Matthew Fortune <Matthew.Fortune@imgtec.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument
Date: Tue, 21 Apr 2015 14:34:37 +0100	[thread overview]
Message-ID: <553651ED.9080209@imgtec.com> (raw)
In-Reply-To: <CAFEAcA9hTMW7wjRhp+Hvp97+sX42vxtQPHW4xBa6c1G0rMxh0Q@mail.gmail.com>

On 16/04/2015 15:22, Peter Maydell wrote:
> On 15 April 2015 at 10:09, Liviu Ionescu <ilg@livius.net> wrote:
>> we currently have two solutions:
>>
>> - multiple: --semihosting-config arg="..."
>> - a single option, placed at the end, and followed by any number
>>   of arguments: --semihosting-cmdline $@ \n
>>
>> both can generate the array of args required by UHI and both can pass
>> args with spaces.
> 
> I strongly dislike the second of these options -- it is nothing like
> the way QEMU's system-emulator mode handles other command line
> arguments. (The user-mode executable is not a good model to try
> to copy, because (a) its sole purpose is executing other binaries
> and passing them command line options (b) it doesn't have the
> QemuOptions infrastructure.)
> 
> I think the first syntax is fine. If you happen to be on ARM where
> there's only a single 'semihosting arguments' string in the ABI
> then you can just say --semihosting-config arg="foo bar baz".
> This has the comma-escaping ugliness, of course, but if you're
> providing a GUI for users anyway it's trivial for the GUI to
> comma-escape things.

The patch which started this thread is the way to go then.

I'll resend the patch with dropped "RFC" as I would really like to go
forward and finally close this issue.

Thanks,
Leon

(PS: --semihosting-cmdline $@ is probably the most convenient from GUI /
wrapper point of view, but I don't have an opinion whether this is
enough to justify adding a top level QEMU command line option with such
a unique syntax)

  reply	other threads:[~2015-04-21 13:34 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-01 13:18 [Qemu-devel] [RFC PATCH] vl.c: add -semihosting-config "arg" sub-argument Leon Alrae
2015-04-01 15:21 ` Liviu Ionescu
2015-04-01 16:12   ` Matthew Fortune
2015-04-02  7:56   ` Leon Alrae
2015-04-02  8:29     ` Liviu Ionescu
2015-04-02  9:14       ` Leon Alrae
2015-04-02 10:36         ` Leon Alrae
2015-04-02 12:36           ` Liviu Ionescu
2015-04-02 14:27             ` Matthew Fortune
2015-04-02 16:47               ` Liviu Ionescu
2015-04-03 15:33                 ` Liviu Ionescu
2015-04-08 16:20                 ` Leon Alrae
2015-04-14 17:42                   ` Liviu Ionescu
2015-04-15  9:09                     ` Liviu Ionescu
2015-04-15 11:53                       ` Leon Alrae
2015-04-15 12:02                         ` Matthew Fortune
2015-04-15 12:06                         ` Liviu Ionescu
2015-04-15 12:49                           ` Leon Alrae
2015-04-15 16:08                             ` Liviu Ionescu
2015-04-16  9:27                               ` Leon Alrae
2015-04-17 17:45                                 ` Liviu Ionescu
2015-04-16 14:22                       ` Peter Maydell
2015-04-21 13:34                         ` Leon Alrae [this message]
2015-04-21 15:14                           ` Liviu Ionescu
2015-04-21 15:55                             ` Peter Maydell
2015-04-21 16:21                               ` Liviu Ionescu
2015-04-21 16:23                                 ` Peter Maydell
2015-04-21 16:51                                   ` Liviu Ionescu
2015-04-21 17:50                                     ` Peter Maydell
2015-04-21 16:48                               ` Eric Blake
2015-04-21 16:54                                 ` Peter Maydell
2015-04-21 17:22                                   ` Eric Blake
2015-04-21 17:49                                   ` Liviu Ionescu
2015-04-21 18:08                           ` Liviu Ionescu
2015-04-23 11:55                             ` Leon Alrae
2015-04-23 12:07                               ` Liviu Ionescu
2015-04-01 15:45 ` Christopher Covington
2015-04-01 16:24   ` Liviu Ionescu
2015-04-04 15:20 ` Liviu Ionescu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553651ED.9080209@imgtec.com \
    --to=leon.alrae@imgtec.com \
    --cc=Matthew.Fortune@imgtec.com \
    --cc=christopher.covington@linaro.org \
    --cc=ilg@livius.net \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).