From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47972)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1YkZqh-0007vP-ND
	for qemu-devel@nongnu.org; Tue, 21 Apr 2015 11:12:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1YkZqd-0002Pq-Ho
	for qemu-devel@nongnu.org; Tue, 21 Apr 2015 11:12:31 -0400
Received: from lhrrgout.huawei.com ([194.213.3.17]:44221)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Claudio.Fontana@huawei.com>) id 1YkZqd-0002PD-AQ
	for qemu-devel@nongnu.org; Tue, 21 Apr 2015 11:12:27 -0400
Message-ID: <553668CA.6030700@huawei.com>
Date: Tue, 21 Apr 2015 17:12:10 +0200
From: Claudio Fontana <claudio.fontana@huawei.com>
MIME-Version: 1.0
References: <1426501911-1402-1-git-send-email-hw.claudio@gmail.com>	<55097E0A.6020808@huawei.com>	<55158312.9050109@huawei.com>
	<20150420180142.58856911@redhat.com>
	<55365DC8.4000004@huawei.com> <55365EA0.5000801@redhat.com>
In-Reply-To: <55365EA0.5000801@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC v3] monitor: add memory search commands s, sp
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>, Claudio Fontana <hw.claudio@gmail.com>, Gonglei <arei.gonglei@huawei.com>, qemu-devel@nongnu.org

On 21.04.2015 16:28, Paolo Bonzini wrote:
> 
> 
> On 21/04/2015 16:25, Claudio Fontana wrote:
>> I seem not to get this warning with the compiler version I am currently using,
>> and after checking the code I could not find out why with some compilers would emit such a warning.
>>
>> It is difficult for me to debug this issue since I do not get this..
>> I am using a slightly older compiler from Linaro for AArch64 (4.8.3 based)
> 
> I would just add a NULL initializer.
> 
> Paolo
> 

Absolutely, yes, I thought about that and just be done with it.

I wonder if that's the right compiler behavior though;
is it acceptable that the compiler cannot figure out that needle is always initialized before use when you have

switch (format) {
case 'c':
    needle = SOMETHING;
...
}

if (format != 'c') {
    needle = SOMETHING_ELSE;
}

actually_use(needle);

?


Ciao,

Claudio