qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Fedorov <serge.fdrv@gmail.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] target-arm: rename c1_coproc to cpacr_el1
Date: Tue, 21 Apr 2015 08:39:58 -0700	[thread overview]
Message-ID: <55366F4E.3040709@gmail.com> (raw)
In-Reply-To: <CAFEAcA9kWBEUbFWJzqAnmexpjPEZbupewXg-0mGmX=UgZ8xe2Q@mail.gmail.com>

On 21.04.2015 06:49, Peter Maydell wrote:
> On 17 March 2015 at 16:23, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 17 March 2015 at 15:33, Sergey Fedorov <serge.fdrv@gmail.com> wrote:
>>> Rename the field holding CPACR_EL1 system register state in AArch64
>>> naming style.
>>>
>>> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>>
>> Mostly I've been renaming these only where we needed to
>> touch them for some other reason, but this one is particularly
>> confusing as a name, I think, and it doesn't touch too many
>> lines to change it.
>>
>> Not for 2.3, though.
> I'm adding this to target-arm.next for 2.4 now, and I
> just noticed that you missed the occurrences in cpu.c.
> If you'd built the linux-user emulators you'd have found
> this because they wouldn't have built :-)
>
> I'll fix this up as I apply the patch.
>
> thanks
> -- PMM

Oh, my fault. Thanks!

Sergey

      reply	other threads:[~2015-04-21 15:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-17 15:33 [Qemu-devel] [PATCH] target-arm: rename c1_coproc to cpacr_el1 Sergey Fedorov
2015-03-17 16:23 ` Peter Maydell
2015-04-21 13:49   ` Peter Maydell
2015-04-21 15:39     ` Sergey Fedorov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55366F4E.3040709@gmail.com \
    --to=serge.fdrv@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).