From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56115)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1YkaHQ-0005t4-FS
	for qemu-devel@nongnu.org; Tue, 21 Apr 2015 11:40:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1YkaHK-000491-Qf
	for qemu-devel@nongnu.org; Tue, 21 Apr 2015 11:40:08 -0400
Received: from mail-pd0-x22e.google.com ([2607:f8b0:400e:c02::22e]:34122)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <serge.fdrv@gmail.com>) id 1YkaHK-00046d-GU
	for qemu-devel@nongnu.org; Tue, 21 Apr 2015 11:40:02 -0400
Received: by pdbqa5 with SMTP id qa5so245082878pdb.1
	for <qemu-devel@nongnu.org>; Tue, 21 Apr 2015 08:40:01 -0700 (PDT)
Message-ID: <55366F4E.3040709@gmail.com>
Date: Tue, 21 Apr 2015 08:39:58 -0700
From: Sergey Fedorov <serge.fdrv@gmail.com>
MIME-Version: 1.0
References: <1426606382-15345-1-git-send-email-serge.fdrv@gmail.com>
	<CAFEAcA8NPhgqMVG8o6VURLDA6TX7ggaRtfw8m31YQR47HX_=pA@mail.gmail.com>
	<CAFEAcA9kWBEUbFWJzqAnmexpjPEZbupewXg-0mGmX=UgZ8xe2Q@mail.gmail.com>
In-Reply-To: <CAFEAcA9kWBEUbFWJzqAnmexpjPEZbupewXg-0mGmX=UgZ8xe2Q@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-arm: rename c1_coproc to cpacr_el1
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 21.04.2015 06:49, Peter Maydell wrote:
> On 17 March 2015 at 16:23, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 17 March 2015 at 15:33, Sergey Fedorov <serge.fdrv@gmail.com> wrote:
>>> Rename the field holding CPACR_EL1 system register state in AArch64
>>> naming style.
>>>
>>> Signed-off-by: Sergey Fedorov <serge.fdrv@gmail.com>
>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
>>
>> Mostly I've been renaming these only where we needed to
>> touch them for some other reason, but this one is particularly
>> confusing as a name, I think, and it doesn't touch too many
>> lines to change it.
>>
>> Not for 2.3, though.
> I'm adding this to target-arm.next for 2.4 now, and I
> just noticed that you missed the occurrences in cpu.c.
> If you'd built the linux-user emulators you'd have found
> this because they wouldn't have built :-)
>
> I'll fix this up as I apply the patch.
>
> thanks
> -- PMM

Oh, my fault. Thanks!

Sergey