Re: [Qemu-devel] [PATCH 1/6] s390x/virtio-ccw: enable has_dynamic_sysbus

[Alexander Graf <agraf@suse.de>]

On 04/17/2015 09:52 AM, Cornelia Huck wrote:
> From: Xu Wang <gesaint@linux.vnet.ibm.com>
>
> We have to enable this flag to support dynamically adding devices to the
> sysbus. This change is needed for the the upcoming diag288 watchdog.

s390 doesn't have a "sysbus" per se. Please create a new bus type.


Alex

>
> Signed-off-by: Xu Wang <gesaint@linux.vnet.ibm.com>
> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
>   hw/s390x/s390-virtio-ccw.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index afb539a..df89440 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -216,6 +216,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data)
>       mc->no_sdcard = 1;
>       mc->use_sclp = 1;
>       mc->max_cpus = 255;
> +    mc->has_dynamic_sysbus = true;
>       nc->nmi_monitor_handler = s390_nmi;
>   }
>