From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52541)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1YkdX8-0005Nr-2Q
	for qemu-devel@nongnu.org; Tue, 21 Apr 2015 15:08:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1YkdX4-0001k9-2Z
	for qemu-devel@nongnu.org; Tue, 21 Apr 2015 15:08:34 -0400
Received: from cantor2.suse.de ([195.135.220.15]:57830 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1YkdX3-0001jO-Rl
	for qemu-devel@nongnu.org; Tue, 21 Apr 2015 15:08:29 -0400
Message-ID: <55369FC2.1090508@suse.de>
Date: Tue, 21 Apr 2015 21:06:42 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1429257161-29597-1-git-send-email-cornelia.huck@de.ibm.com>
	<1429257161-29597-2-git-send-email-cornelia.huck@de.ibm.com>
In-Reply-To: <1429257161-29597-2-git-send-email-cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/6] s390x/virtio-ccw: enable
	has_dynamic_sysbus
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>, qemu-devel@nongnu.org
Cc: mdroth@linux.vnet.ibm.com, armbru@redhat.com, borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, Xu Wang <gesaint@linux.vnet.ibm.com>, lcapitulino@redhat.com

On 04/17/2015 09:52 AM, Cornelia Huck wrote:
> From: Xu Wang <gesaint@linux.vnet.ibm.com>
>
> We have to enable this flag to support dynamically adding devices to the
> sysbus. This change is needed for the the upcoming diag288 watchdog.

s390 doesn't have a "sysbus" per se. Please create a new bus type.


Alex

>
> Signed-off-by: Xu Wang <gesaint@linux.vnet.ibm.com>
> Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> Reviewed-by: David Hildenbrand <dahi@linux.vnet.ibm.com>
> Signed-off-by: Cornelia Huck <cornelia.huck@de.ibm.com>
> ---
>   hw/s390x/s390-virtio-ccw.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c
> index afb539a..df89440 100644
> --- a/hw/s390x/s390-virtio-ccw.c
> +++ b/hw/s390x/s390-virtio-ccw.c
> @@ -216,6 +216,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data)
>       mc->no_sdcard = 1;
>       mc->use_sclp = 1;
>       mc->max_cpus = 255;
> +    mc->has_dynamic_sysbus = true;
>       nc->nmi_monitor_handler = s390_nmi;
>   }
>