From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55782)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1Ykqlj-0004lo-Ez
	for qemu-devel@nongnu.org; Wed, 22 Apr 2015 05:16:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1Ykqlg-00048E-QZ
	for qemu-devel@nongnu.org; Wed, 22 Apr 2015 05:16:31 -0400
Received: from cantor2.suse.de ([195.135.220.15]:38594 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1Ykqlg-000482-Kq
	for qemu-devel@nongnu.org; Wed, 22 Apr 2015 05:16:28 -0400
Message-ID: <55376680.3070601@suse.de>
Date: Wed, 22 Apr 2015 11:14:40 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
References: <1429257161-29597-1-git-send-email-cornelia.huck@de.ibm.com>	<1429257161-29597-2-git-send-email-cornelia.huck@de.ibm.com>	<55369FC2.1090508@suse.de>
	<20150422102501.406fc113.cornelia.huck@de.ibm.com>
In-Reply-To: <20150422102501.406fc113.cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 1/6] s390x/virtio-ccw: enable
	has_dynamic_sysbus
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: armbru@redhat.com, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com, Xu Wang <gesaint@linux.vnet.ibm.com>, lcapitulino@redhat.com

On 04/22/2015 10:25 AM, Cornelia Huck wrote:
> On Tue, 21 Apr 2015 21:06:42 +0200
> Alexander Graf <agraf@suse.de> wrote:
>
>> On 04/17/2015 09:52 AM, Cornelia Huck wrote:
>>> From: Xu Wang <gesaint@linux.vnet.ibm.com>
>>>
>>> We have to enable this flag to support dynamically adding devices to the
>>> sysbus. This change is needed for the the upcoming diag288 watchdog.
>> s390 doesn't have a "sysbus" per se. Please create a new bus type.
> So what's wrong with the sysbus? I don't see why we should be different
> than everyone else.

The idea behind sysbus is that you have MMIO, PIO and IRQ pins 
connecting to a PIC. It provides a lot of infrastructure for those 
interfaces. S390 doesn't use any of them and instead wants registration 
on "diag" interfaces for example which I'd put on the same layer as PIO 
or MMIO registration.


Alex