From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43503) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkreY-0005F0-RW for qemu-devel@nongnu.org; Wed, 22 Apr 2015 06:13:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkreV-0002gE-M8 for qemu-devel@nongnu.org; Wed, 22 Apr 2015 06:13:10 -0400 Sender: Paolo Bonzini Message-ID: <5537742A.90504@redhat.com> Date: Wed, 22 Apr 2015 12:12:58 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1428055280-12015-1-git-send-email-wency@cn.fujitsu.com> <1428055280-12015-2-git-send-email-wency@cn.fujitsu.com> <20150420153047.GB32653@stefanha-thinkpad.redhat.com> <5535A727.5080402@cn.fujitsu.com> <55366C81.1080202@redhat.com> <20150422093101.GD3882@noname.redhat.com> In-Reply-To: <20150422093101.GD3882@noname.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH COLO v3 01/14] docs: block replication's description List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Fam Zheng , Lai Jiangshan , qemu block , Jiang Yunhong , Dong Eddie , qemu devel , Max Reitz , Gonglei , Stefan Hajnoczi , Yang Hongyang , "Dr. David Alan Gilbert" , zhanghailiang On 22/04/2015 11:31, Kevin Wolf wrote: >> Actually I liked the "foo+colo" names. >> >> These are just internal details of the implementations and the >> primary/secondary disks actually can be any format. >> >> Stefan, what was your worry with the +colo block drivers? > > I haven't read the patches yet, so I may be misunderstanding, but > wouldn't a separate filter driver be more appropriate than modifying > qcow2 with logic that has nothing to do with the image format? Possibly; on the other hand, why multiply the size of the test matrix with options that no one will use and that will bitrot? Paolo