From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57450)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Ykvgq-0004OQ-Md
	for qemu-devel@nongnu.org; Wed, 22 Apr 2015 10:31:49 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Ykvgl-0005iO-H8
	for qemu-devel@nongnu.org; Wed, 22 Apr 2015 10:31:48 -0400
Received: from mx1.redhat.com ([209.132.183.28]:41344)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jsnow@redhat.com>) id 1Ykvgl-0005iC-7i
	for qemu-devel@nongnu.org; Wed, 22 Apr 2015 10:31:43 -0400
Received: from int-mx13.intmail.prod.int.phx2.redhat.com
	(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3MEVg5S021692
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256
	verify=FAIL)
	for <qemu-devel@nongnu.org>; Wed, 22 Apr 2015 10:31:42 -0400
Message-ID: <5537B0CD.1010807@redhat.com>
Date: Wed, 22 Apr 2015 10:31:41 -0400
From: John Snow <jsnow@redhat.com>
MIME-Version: 1.0
References: <1429668155-1606-1-git-send-email-jsnow@redhat.com>
	<1429668155-1606-3-git-send-email-jsnow@redhat.com>
	<5537B020.4000408@redhat.com>
In-Reply-To: <5537B020.4000408@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/5] scripts: qmp-shell: add support for []
 expressions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: kchamart@redhat.com, lcapitulino@redhat.com



On 04/22/2015 10:28 AM, Eric Blake wrote:
> On 04/21/2015 08:02 PM, John Snow wrote:
>> qmp-shell currently allows you to describe values as
>> JSON expressions:
>>
>> key={"key":{"key2":"val"}}
>>
>> But it does not currently support arrays, which are needed
>> for serializing and deserializing transactions:
>>
>> key=[{"type":"drive-backup","data":{...}}]
>>
>> Add support for arrays.
>>
>> CAVEAT: The parser is still extremely rudimentary and does not
>> expect to find spaces in {} nor [] expressions. This patch does
>> not improve this functionality.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> ---
>>   scripts/qmp/qmp-shell | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell
>> index a9632ec..5347f89 100755
>> --- a/scripts/qmp/qmp-shell
>> +++ b/scripts/qmp/qmp-shell
>> @@ -102,6 +102,8 @@ class QMPShell(qmp.QEMUMonitorProtocol):
>>                       value = False
>>                   elif opt[1].startswith('{'):
>>                       value = json.loads(opt[1])
>> +                elif opt[1].startswith('['):
>> +                    value = json.loads(opt[1])
>
> Why not:
>
> elif opt[1].startswith('{'} or opt[1].startswith('['):
>

Didn't really consider this patch too long is why :)
If the rest of it looks worth checking in to you, I'll make the tidying 
edits.

> for a one-line change instead of two-line addition?  And I'm no python
> expert, but I think you can write that with fewer characters. Untested,
> but does this work?
>
> elif opt[1][0] in "{[":
>

It should.

Thanks,
--js