From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkwZL-0007yh-7x for qemu-devel@nongnu.org; Wed, 22 Apr 2015 11:28:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkwZH-0008BB-7X for qemu-devel@nongnu.org; Wed, 22 Apr 2015 11:28:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43057) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkwZH-0008B5-3H for qemu-devel@nongnu.org; Wed, 22 Apr 2015 11:28:03 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id ADE83B5E96 for ; Wed, 22 Apr 2015 15:28:02 +0000 (UTC) Message-ID: <5537BE01.2090604@redhat.com> Date: Wed, 22 Apr 2015 09:28:01 -0600 From: Eric Blake MIME-Version: 1.0 References: <1429668155-1606-1-git-send-email-jsnow@redhat.com> <1429668155-1606-5-git-send-email-jsnow@redhat.com> <5537B4B1.9060408@redhat.com> <5537B816.4040907@redhat.com> In-Reply-To: <5537B816.4040907@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="uUW7IpVcHNXQtxrJ0VFtNGBrBgsveSsMq" Subject: Re: [Qemu-devel] [PATCH 4/5] scripts: qmp-shell: add transaction subshell List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kchamart@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uUW7IpVcHNXQtxrJ0VFtNGBrBgsveSsMq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/22/2015 09:02 AM, John Snow wrote: > Yeah, not a big deal. The function that invokes this one actually > explicitly checks for an empty string and avoids __build_cmd already. >=20 > If it gets spaces, It actually currently errors out with "list index ou= t > of range" which is not helpful or interesting. >=20 > This will at least improve it to do "nothing." >=20 > The behavior of just ignoring empty and blank lines is suitable > regardless of mode, I think, unless you have a counter argument. No counter argument here; but it does mean that we should improve the commit message, to mention that it is an intentionally nice side effect of the change :) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --uUW7IpVcHNXQtxrJ0VFtNGBrBgsveSsMq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVN74BAAoJEKeha0olJ0Nq9OAH/AnhgBd3YIaiDT4ioX6dVaaX yyGowcLtRncUmREE9ryEyHx318BFpmnuYlYZj/2B2eA3KMFAAIxCQEgXFR4bBg4W SOrOtA+AzedOcif6C7RbWDmrrHQTKvULG+Iqn7y21Y2R2DD3+aWZSFC7vlvo3tpB YRlWMfBm7Rdbfi2oR7zqpX59uvzlJd05e0GPr4M5g+kglxwFOcq66vVd6HfyyB1G MUucGZ04gNevSm8sczm36GBI0S2eDBQp0OCWGdsY8ZqtvMDVkf2NPqh/lJxLcXJE lhspxYI3LcdlYlmXDaSydi/egDdbECmhPZNDn50fB4FNtIMuEnMPXOodb5YV9iU= =20eq -----END PGP SIGNATURE----- --uUW7IpVcHNXQtxrJ0VFtNGBrBgsveSsMq--