From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ykxak-000233-9e for qemu-devel@nongnu.org; Wed, 22 Apr 2015 12:33:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ykxah-0004VD-2F for qemu-devel@nongnu.org; Wed, 22 Apr 2015 12:33:38 -0400 Message-ID: <5537CD59.5090805@redhat.com> Date: Wed, 22 Apr 2015 18:33:29 +0200 From: Max Reitz MIME-Version: 1.0 References: <1429314609-29776-1-git-send-email-jsnow@redhat.com> <1429314609-29776-11-git-send-email-jsnow@redhat.com> In-Reply-To: <1429314609-29776-11-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 10/21] qmp: Add support of "dirty-bitmap" sync mode for drive-backup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com, vsementsov@parallels.com, stefanha@redhat.com On 18.04.2015 01:49, John Snow wrote: > For "dirty-bitmap" sync mode, the block job will iterate through the > given dirty bitmap to decide if a sector needs backup (backup all the > dirty clusters and skip clean ones), just as allocation conditions of > "top" sync mode. > > Signed-off-by: Fam Zheng > Signed-off-by: John Snow > --- > block.c | 9 +++ > block/backup.c | 155 +++++++++++++++++++++++++++++++++++++++------- > block/mirror.c | 4 ++ > blockdev.c | 18 +++++- > hmp.c | 3 +- > include/block/block.h | 1 + > include/block/block_int.h | 2 + > qapi/block-core.json | 14 +++-- > qmp-commands.hx | 8 ++- > 9 files changed, 181 insertions(+), 33 deletions(-) Reviewed-by: Max Reitz