From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkyG5-000191-IO for qemu-devel@nongnu.org; Wed, 22 Apr 2015 13:16:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkyG4-0001f7-NC for qemu-devel@nongnu.org; Wed, 22 Apr 2015 13:16:21 -0400 Message-ID: <5537D732.6030802@redhat.com> Date: Wed, 22 Apr 2015 19:15:30 +0200 From: Max Reitz MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/8] block: allow block jobs in any arbitrary node List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Stefan Hajnoczi On 16.04.2015 17:12, Alberto Garcia wrote: > Currently, block jobs can only be owned by root nodes. This patch > allows block jobs to be in any arbitrary node, by making the following > changes: > > - Block jobs can now be identified by the node name of their > BlockDriverState in addition to the device name. Since both device > and node names live in the same namespace there's no ambiguity. > > - The "device" parameter used by all commands that operate on block > jobs can also be a node name now. > > - The node name is used as a fallback to fill in the BlockJobInfo > structure and all BLOCK_JOB_* events if there is no device name for > that job. > > Signed-off-by: Alberto Garcia > --- > block/mirror.c | 5 +++-- > blockdev.c | 16 ++++++++-------- > blockjob.c | 18 ++++++++++-------- > docs/qmp/qmp-events.txt | 8 ++++---- > include/qapi/qmp/qerror.h | 3 --- > qapi/block-core.json | 20 ++++++++++---------- > 6 files changed, 35 insertions(+), 35 deletions(-) Reviewed-by: Max Reitz