From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46879) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkyOa-0000OM-VD for qemu-devel@nongnu.org; Wed, 22 Apr 2015 13:25:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkyOW-00058D-9U for qemu-devel@nongnu.org; Wed, 22 Apr 2015 13:25:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60273) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkyOW-00057n-3t for qemu-devel@nongnu.org; Wed, 22 Apr 2015 13:25:04 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id C9B8591C0A for ; Wed, 22 Apr 2015 17:25:03 +0000 (UTC) Message-ID: <5537D96E.40308@redhat.com> Date: Wed, 22 Apr 2015 11:25:02 -0600 From: Eric Blake MIME-Version: 1.0 References: <1429719709-880-1-git-send-email-jsnow@redhat.com> <1429719709-880-3-git-send-email-jsnow@redhat.com> <5537D7F1.1090700@redhat.com> In-Reply-To: <5537D7F1.1090700@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="c2ptpTVqKU4m2o7hfv5cMscOjUUxOpH3A" Subject: Re: [Qemu-devel] [PATCH v2 2/4] scripts: qmp-shell: Expand support for QMP expressions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kchamart@redhat.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --c2ptpTVqKU4m2o7hfv5cMscOjUUxOpH3A Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/22/2015 11:18 AM, Eric Blake wrote: > On 04/22/2015 10:21 AM, John Snow wrote: >> This includes support for [] expressions, single-quotes in >> QMP expressions (which is not strictly a part of JSON), and >> the ability to use "True" or "False" literals instead of >> JSON's lowercased 'true' and 'false' literals. >> >> >> Signed-off-by: John Snow >> --- >> scripts/qmp/qmp-shell | 44 ++++++++++++++++++++++++++++--------------= -- >> 1 file changed, 28 insertions(+), 16 deletions(-) >=20 > As far as I can tell, this makes qmp-shell strictly more useful, so I > have no qualms giving: >=20 > Reviewed-by: Eric Blake When combined with your one-line touchup, of course. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --c2ptpTVqKU4m2o7hfv5cMscOjUUxOpH3A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVN9luAAoJEKeha0olJ0NqJ30IAIzB8d5u3aYPT0Mu7P6YecEo v6AGi0fIH8vb1DgH8p/Eoc8gtUgEg2cx0ShTLTOsSBamDgsCLxoim0qXSRZWuOwF 9JDgU0KO3DWkHJRXtfs5U5MdCYEtfkUh7R24xS45grYq1xr4Nlovq0h8z5bOvO58 fGn8G1d5CalqMnwi2hHM1FGcdHx1AHoqWyvi9lUGMDRZKOd6V3U3D7EFniXqErzc owiFUb458ae6J2rJ5SjX1aNxeSdcBhnSsKLSDJBoj2119zAC3pROxnSNqpCWNxfK O+nlF4Xe31p/N4Knweux9GMtt2doBV+yY2vNBjHXKbUww8IpIGcd5j3hE64aBa0= =Oo0X -----END PGP SIGNATURE----- --c2ptpTVqKU4m2o7hfv5cMscOjUUxOpH3A--