From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YkyrN-0002Ke-VE for qemu-devel@nongnu.org; Wed, 22 Apr 2015 13:54:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YkyrN-00058D-3j for qemu-devel@nongnu.org; Wed, 22 Apr 2015 13:54:53 -0400 Message-ID: <5537E039.4000502@redhat.com> Date: Wed, 22 Apr 2015 19:54:01 +0200 From: Max Reitz MIME-Version: 1.0 References: <5665024c0f933ff30b527f3da02c842c79156fd6.1429196435.git.berto@igalia.com> In-Reply-To: <5665024c0f933ff30b527f3da02c842c79156fd6.1429196435.git.berto@igalia.com> Content-Type: text/plain; charset=iso-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/8] qemu-iotests: fix test_stream_partial() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Stefan Hajnoczi On 16.04.2015 17:12, Alberto Garcia wrote: > This test is streaming to the top layer using the intermediate image > as the base. This is a mistake since block-stream never copies data > from the base image and its backing chain, so this is effectively a > no-op. > > In addition to fixing the base parameter, this patch also writes some > data to the intermediate image before the test, so there's anything to > copy and the test is meaningful. > > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/030 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Max Reitz