From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53960) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yl0jJ-0006ei-Tw for qemu-devel@nongnu.org; Wed, 22 Apr 2015 15:54:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yl0jI-00059d-Vq for qemu-devel@nongnu.org; Wed, 22 Apr 2015 15:54:41 -0400 Message-ID: <5537FC79.5090809@redhat.com> Date: Wed, 22 Apr 2015 13:54:33 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="T9kFmM0AJw6CbfsWM787ldBox5g9cmSPB" Subject: Re: [Qemu-devel] [PATCH 8/8] qemu-iotests: test streaming to an intermediate layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Stefan Hajnoczi , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --T9kFmM0AJw6CbfsWM787ldBox5g9cmSPB Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/16/2015 09:12 AM, Alberto Garcia wrote: > This adds test_stream_intermediate(), similar to test_stream() but > streams to the intermediate image instead. >=20 > Signed-off-by: Alberto Garcia > --- > tests/qemu-iotests/030 | 18 +++++++++++++++++- > tests/qemu-iotests/030.out | 4 ++-- > 2 files changed, 19 insertions(+), 3 deletions(-) >=20 I'm wondering if we should also test a multi-file stream. That is, starting from: A <- B <- C <- D <- E and rebasing so that A is the backing file of D (pulling both B and C into D): A <- D <- E we should be able to verify that B and C are unchanged, and that D picked up changes from both intermediate files (in particular, it's nice to test that we aren't being inefficient by breaking the operation into two steps: streaming B into C then C into D would give the same end result in D, but would waste time for any clusters in B that were not changed in C but were changed in D). But such a test could be a separate patch, so I don't see anything wrong with this new test as-is. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --T9kFmM0AJw6CbfsWM787ldBox5g9cmSPB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVN/x5AAoJEKeha0olJ0NqiOQH/3sR7mQvvtdXbrLq4EAB+Hwy ZaIcRvwnIF8ie6DUOqniqH/KV/cjD3FmiGjYi6P6EJl5WgudR/RCfFXnqgfLYsUm ytjPmx7Lh7UcJ4tfz4tl3IiNe+uKR+LVLmTfvh7NcYicKU4LlL3vzgpeJtaZKJjy fW3n9qnG3g8ZbivcjkY5iyXedfCko7/EKTCpfPcav7+l6qSzoCdu1AvKUPJNzCos cuOzjiyjomYxWFDlZG/MzSjsg7IwkXHWIwyEyEstSWGGEWXjR/N0dBc3wu4ANTRU qTVVU4/nRdbSHWBEV+FFnWpDGawrPwrU8bEX7r4izQLAEVtcEso1j+QtZvDFwnM= =X+d8 -----END PGP SIGNATURE----- --T9kFmM0AJw6CbfsWM787ldBox5g9cmSPB--