From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57817) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yl0vI-0002T9-8p for qemu-devel@nongnu.org; Wed, 22 Apr 2015 16:07:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yl0vH-0003TU-1z for qemu-devel@nongnu.org; Wed, 22 Apr 2015 16:07:04 -0400 Message-ID: <5537FF37.8070902@redhat.com> Date: Wed, 22 Apr 2015 14:06:15 -0600 From: Eric Blake MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8urT5A9dR0cWsTnHcD35IKiA7MvjdgvOM" Subject: Re: [Qemu-devel] [PATCH 2/8] block: allow block jobs in any arbitrary node List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-block@nongnu.org, Stefan Hajnoczi , Max Reitz This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8urT5A9dR0cWsTnHcD35IKiA7MvjdgvOM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/16/2015 09:12 AM, Alberto Garcia wrote: > Currently, block jobs can only be owned by root nodes. This patch > allows block jobs to be in any arbitrary node, by making the following > changes: >=20 > - Block jobs can now be identified by the node name of their > BlockDriverState in addition to the device name. Since both device > and node names live in the same namespace there's no ambiguity. >=20 > - The "device" parameter used by all commands that operate on block > jobs can also be a node name now. >=20 > - The node name is used as a fallback to fill in the BlockJobInfo > structure and all BLOCK_JOB_* events if there is no device name for > that job. >=20 > Signed-off-by: Alberto Garcia > --- > block/mirror.c | 5 +++-- > blockdev.c | 16 ++++++++-------- > blockjob.c | 18 ++++++++++-------- > docs/qmp/qmp-events.txt | 8 ++++---- > include/qapi/qmp/qerror.h | 3 --- > qapi/block-core.json | 20 ++++++++++---------- > 6 files changed, 35 insertions(+), 35 deletions(-) >=20 > +++ b/docs/qmp/qmp-events.txt > @@ -89,7 +89,7 @@ Data: > =20 > - "type": Job type (json-string; "stream" for image streaming > "commit" for block commit) > -- "device": Device name (json-string) > +- "device": Device name, or node name if not present (json-string) You used this wording for all the events... > +++ b/qapi/block-core.json > @@ -540,7 +540,7 @@ > # > # @type: the job type ('stream' for image streaming) > # > -# @device: the block device name > +# @device: the block device name, or node name if not present > # and again here, > # @len: the maximum progress value > # > @@ -1065,7 +1065,7 @@ > # > # Throttling can be disabled by setting the speed to 0. > # > -# @device: the device name > +# @device: the device or node name of the owner of the block job. but this wording is different. I like it a bit better ("node name if not present" feels like it could be a bit ambiguous as to what is not present, and "device or node name" is shorter than "device name, or node name if not present"). I'm not sure if it's worth changing, and I could live with the patch as-is, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8urT5A9dR0cWsTnHcD35IKiA7MvjdgvOM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJVN/83AAoJEKeha0olJ0NqmaMH/2/RCsqWrJn5wXWrBgp7bDTU 1GbMPq1SyH6X4cdoUxMfVLhTlqCkBK60qXfkkya3/TFsDunigyU1I0aSFTrvqFVh 4y8Ek1sLUTkJBUAU9rYm04c/0PzRwhhX7o5kWJTHvJjzkwVyLpQyYc49WmzpEy8M uVdcdvt5BCUEbKmQIGLnU32QhJ9QTrMdY0AIjO9g7QonRqJax2979CX9+iVyUNnJ vmfCa1HKrK9ovLDfr3vXCNQ/gcnysMf04tCr1i2xOFM25aqsQ5CGpXvtSZAVCIfC UGh7rAtUL7ddk0ce/orLnM6chtPVdih4uuPPugYHiUsdMKDbA2MTblSR+moZbaM= =x3dx -----END PGP SIGNATURE----- --8urT5A9dR0cWsTnHcD35IKiA7MvjdgvOM--