From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38825)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shannon.zhao@linaro.org>) id 1Yl53O-0005qF-6z
	for qemu-devel@nongnu.org; Wed, 22 Apr 2015 20:31:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <shannon.zhao@linaro.org>) id 1Yl53J-0003Ql-7e
	for qemu-devel@nongnu.org; Wed, 22 Apr 2015 20:31:42 -0400
Received: from mail-pd0-f174.google.com ([209.85.192.174]:34523)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <shannon.zhao@linaro.org>) id 1Yl53J-0003Qf-2e
	for qemu-devel@nongnu.org; Wed, 22 Apr 2015 20:31:37 -0400
Received: by pdbqa5 with SMTP id qa5so2873759pdb.1
	for <qemu-devel@nongnu.org>; Wed, 22 Apr 2015 17:31:35 -0700 (PDT)
Message-ID: <55383D5E.5050708@linaro.org>
Date: Thu, 23 Apr 2015 08:31:26 +0800
From: Shannon Zhao <shannon.zhao@linaro.org>
MIME-Version: 1.0
References: <1429613471-7944-1-git-send-email-shannon.zhao@linaro.org>	<1429613471-7944-2-git-send-email-shannon.zhao@linaro.org>
	<20150422162410.10c36694.cornelia.huck@de.ibm.com>
In-Reply-To: <20150422162410.10c36694.cornelia.huck@de.ibm.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 1/2] hw/net/virtio-net: Move
 DEFINE_VIRTIO_NET_FEATURES to virtio-net
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: peter.maydell@linaro.org, hangaohuai@huawei.com, mst@redhat.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, zhaoshenglong@huawei.com, pbonzini@redhat.com, christoffer.dall@linaro.org

On 2015/4/22 22:24, Cornelia Huck wrote:
> On Tue, 21 Apr 2015 18:51:10 +0800
> shannon.zhao@linaro.org wrote:
> 
> I'd drop the leading "hw/net/" from the subject.
> 

Ok, thanks.

>> From: Shannon Zhao <shannon.zhao@linaro.org>
>>
>> Move DEFINE_VIRTIO_NET_FEATURES to the backend virtio-net.
>> The transports just sync the host features from backend.
>> Meanwhile move virtio_net_set_config_size to virtio-net.
> 
> Could you elaborate on why this makes sense?
> 

Ok, will add.

>>
>> Signed-off-by: Shannon Zhao <zhaoshenglong@huawei.com>
>> Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
>> ---
>>  hw/net/virtio-net.c            | 5 +++++
>>  hw/s390x/s390-virtio-bus.c     | 2 --
>>  hw/s390x/virtio-ccw.c          | 2 --
>>  hw/virtio/virtio-pci.c         | 2 --
>>  include/hw/virtio/virtio-net.h | 1 +
>>  5 files changed, 6 insertions(+), 6 deletions(-)
> 
> FWIW, this survives basic sanity checks on virtio-ccw - also in
> combination with my realization sequence reordering patches I sent
> yesterday.
> 
> Haven't gotten around to s390-virtio or virtio-scsi yet.
> 

-- 
Shannon